fix: prevent multiple account creations in the same flow.

[montelaidev]

Description

This pr prevents the creation of multiple accounts when clicking the create button multiple times prior to the modal closing.

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/MMMULTISRP-134?atlOrigin=eyJpIjoiOTAzNjNjNmJlNTc2NDllNjliZTE5MDYwN2M5NmUxYTYiLCJwIjoiaiJ9

Manual testing steps

1. Go to account menu
2. Click on solana and go to the modal
3. Click on the modal multiple times and see that only one account has been created after the modal closes.

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

✨ Files requiring CODEOWNER review ✨

🖥️ @MetaMask/wallet-ux

• ui/components/multichain/create-snap-account/create-snap-account.test.tsx
• ui/components/multichain/create-snap-account/create-snap-account.tsx

[metamaskbot]

Builds ready [2be8c0e]

• builds: chrome, firefox
• builds (flask): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• bundle size: Bundle Size Stats
• user-actions-benchmark: User Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all CircleCI artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7, 8
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
  • content-script: 0
  • offscreen: 0

UI Startup Metrics (1180 ± 62 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1180	1069	1357	62	1232	1295
			load	1023	925	1170	59	957	994
			domContentLoaded	1017	921	1166	59	957	990
			domInteractive	16	13	38	4	16	25
			firstPaint	733	79	1168	397	270	984
			backgroundConnect	9	6	58	6	9	10
			firstReactRender	20	15	41	6	19	35
			getState	11	3	38	8	6	8
			initialActions	0	0	1	0	0	1
			loadScripts	806	715	950	58	851	921
			setupStore	7	4	18	2	7	8
	Webpack	Home	uiStartup	2124	1708	2641	239	2241	2615
			load	1647	1331	2054	184	1757	2014
			domContentLoaded	1640	1328	2021	180	1753	1988
			domInteractive	17	13	59	11	14	52
			firstPaint	222	67	1805	221	223	338
			backgroundConnect	28	13	87	17	30	77
			firstReactRender	190	54	363	116	85	95
			getState	12	3	260	25	8	9
			initialActions	3	1	4	1	3	4
			loadScripts	1632	1324	1995	176	1749	1960
			setupStore	31	7	277	63	22	9
Firefox	Browserify	Home	uiStartup	1367	1172	2007	156	1397	1792
			load	1230	1055	1850	151	1264	1627
			domContentLoaded	1230	1055	1850	152	1263	1626
			domInteractive	99	40	183	24	87	97
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	24	17	111	11	24	33
			firstReactRender	23	19	50	5	25	30
			getState	7	3	21	2	7	8
			initialActions	0	0	1	0	0	1
			loadScripts	1208	1037	1829	151	1241	1603
			setupStore	6	3	11	2	6	7
	Webpack	Home	uiStartup	1578	1321	2110	164	1639	1960
			load	1362	1148	1915	152	1434	1713
			domContentLoaded	1362	1147	1915	152	1433	1712
			domInteractive	101	41	157	24	90	97
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	25	17	71	7	26	34
			firstReactRender	35	29	64	6	37	48
			getState	10	4	60	9	7	9
			initialActions	0	0	3	1	1	1
			loadScripts	1339	1130	1892	151	1412	1681
			setupStore	8	5	45	6	7	9

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 351 Bytes (0.01%)
• ui: 11.76 KiB (0.17%)
• common: -157 Bytes (0%)

[metamaskbot]

Builds ready [bf910f5]

• builds: chrome, firefox
• builds (flask): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• bundle size: Bundle Size Stats
• user-actions-benchmark: User Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all CircleCI artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7, 8
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
  • content-script: 0
  • offscreen: 0

UI Startup Metrics (1286 ± 73 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1286	1118	1449	73	1337	1430
			load	1119	992	1310	74	1177	1279
			domContentLoaded	1112	970	1305	74	1183	970
			domInteractive	18	14	50	6	18	31
			firstPaint	802	87	1311	435	220	287
			backgroundConnect	11	7	35	5	9	10
			firstReactRender	20	15	40	4	20	30
			getState	13	5	36	7	6	9
			initialActions	0	0	1	0	0	1
			loadScripts	888	750	1070	73	922	986
			setupStore	8	5	18	2	8	9
	Webpack	Home	uiStartup	2146	1711	2876	232	2253	2596
			load	1660	1350	2081	174	1761	2006
			domContentLoaded	1652	1347	2049	170	1757	1989
			domInteractive	17	12	62	12	14	54
			firstPaint	197	75	391	69	251	376
			backgroundConnect	31	15	230	26	30	76
			firstReactRender	212	54	356	112	86	94
			getState	12	3	296	29	8	9
			initialActions	3	1	4	1	3	4
			loadScripts	1644	1344	2022	166	1754	1963
			setupStore	30	7	306	59	20	9
Firefox	Browserify	Home	uiStartup	1394	1170	1890	151	1423	1783
			load	1254	1053	1741	143	1298	1622
			domContentLoaded	1254	1052	1740	143	1298	1621
			domInteractive	102	37	223	29	87	97
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	26	17	135	17	25	43
			firstReactRender	22	19	48	4	24	27
			getState	7	4	25	3	7	8
			initialActions	0	0	1	0	0	1
			loadScripts	1229	1035	1717	139	1274	1594
			setupStore	6	4	17	2	6	7
	Webpack	Home	uiStartup	1511	1326	2067	162	1546	1973
			load	1307	1143	1851	150	1350	1719
			domContentLoaded	1307	1142	1851	150	1350	1718
			domInteractive	92	40	183	26	90	97
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	23	17	63	6	24	34
			firstReactRender	33	28	50	4	35	41
			getState	7	4	30	5	7	9
			initialActions	0	0	2	1	1	1
			loadScripts	1285	1121	1831	149	1332	1697
			setupStore	7	4	21	2	7	8

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 351 Bytes (0.01%)
• ui: 12.38 KiB (0.18%)
• common: 63 Bytes (0%)

[darkwing]

Better solution could just be to disable the button upon click via local state.

[darkwing]

Actually, I'd prefer we disable the button; that's a known, good UX practice rather than making an element look actionable when it isn't