fix: prevent multiple account creations in the same flow. (#31543)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

This pr prevents the creation of multiple accounts when clicking the
create button multiple times prior to the modal closing.

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/31543?quickstart=1)

## **Related issues**

Fixes:
https://consensyssoftware.atlassian.net/browse/MMMULTISRP-134?atlOrigin=eyJpIjoiOTAzNjNjNmJlNTc2NDllNjliZTE5MDYwN2M5NmUxYTYiLCJwIjoiaiJ9

## **Manual testing steps**

1. Go to account menu
2. Click on solana and go to the modal
3. Click on the modal multiple times and see that only one account has
been created after the modal closes.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

Author: montelaidev

ui/components/multichain/create-snap-account/create-snap-account.test.tsx

@@ -144,4 +144,17 @@ describe('CreateSnapAccount', () => {
       });
     });
   });
+
+  it('only calls createAccount once', async () => {
+    const { getByTestId } = render();
+
+    const createButton = getByTestId('submit-add-account-with-name');
+    fireEvent.click(createButton);
+    fireEvent.click(createButton);
+    fireEvent.click(createButton);
+
+    await waitFor(() => {
+      expect(mockCreateAccount).toHaveBeenCalledTimes(1);
+    });
+  });
 });

ui/components/multichain/create-snap-account/create-snap-account.tsx

@@ -1,4 +1,4 @@
-import React, { useCallback } from 'react';
+import React, { useCallback, useRef } from 'react';
 import { CaipChainId } from '@metamask/utils';
 import { KeyringTypes } from '@metamask/keyring-controller';
 import { getNextAvailableAccountName } from '../../../store/actions';
@@ -43,10 +43,16 @@ export const CreateSnapAccount = ({
   chainId,
 }: CreateSnapAccountProps) => {
   const snapClient = useMultichainWalletSnapClient(clientType);
+  const isCreatingAccount = useRef(false);
 
   const onCreateAccount = useCallback(
     async (_accountNameSuggestion?: string) => {
+      if (isCreatingAccount.current) {
+        return;
+      }
+
       try {
+        isCreatingAccount.current = true;
         await snapClient.createAccount({
           scope: chainId,
           ///: BEGIN:ONLY_INCLUDE_IF(multi-srp)
@@ -57,6 +63,8 @@ export const CreateSnapAccount = ({
         onActionComplete(true);
       } catch (error) {
         onActionComplete(false);
+      } finally {
+        isCreatingAccount.current = false;
       }
     },
     [snapClient, chainId, selectedKeyringId, onActionComplete],