fix: Display "🦊 Smart contract" in "interacting with" row for batch transaction confirmations #31507

vinistevam · 2025-04-02T08:35:10Z

Description

This PR aims to hide the interacting with row when the transaction is a batch transaction.

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/4504

Manual testing steps

On v12.15, kickoff a 5792 send call for the first time
Notice the Interacting with row with your own account as the value

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-04-02T08:35:24Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2025-04-02T08:36:50Z

✨ Files requiring CODEOWNER review ✨

✅ @MetaMask/confirmations

ui/pages/confirmations/components/confirm/info/shared/transaction-details/transaction-details.test.tsx
ui/pages/confirmations/components/confirm/info/shared/transaction-details/transaction-details.tsx

metamaskbot · 2025-04-02T09:12:17Z

Builds ready [6ba7186]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

UI Startup Metrics (1243 ± 63 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1243	1109	1420	63	1284	1351
			load	1084	956	1240	61	1165	994
			domContentLoaded	1078	952	1236	61	1152	987
			domInteractive	17	14	34	4	17	29
			firstPaint	770	136	1262	418	241	986
			backgroundConnect	12	7	158	15	9	10
			firstReactRender	20	13	42	5	20	33
			getState	11	4	30	6	7	8
			initialActions	0	0	1	0	0	1
			loadScripts	857	743	1012	61	901	956
			setupStore	8	5	26	3	7	9
	Webpack	Home	uiStartup	2147	1701	2753	236	2273	2573
			load	1675	1326	2134	190	1801	1984
			domContentLoaded	1668	1322	2101	187	1796	1967
			domInteractive	18	12	70	13	14	55
			firstPaint	195	72	416	72	250	75
			backgroundConnect	30	14	234	26	30	73
			firstReactRender	181	58	358	113	84	95
			getState	9	3	29	4	8	9
			initialActions	3	1	6	1	3	4
			loadScripts	1659	1319	2075	184	1793	1941
			setupStore	39	6	289	73	25	9
Firefox	Browserify	Home	uiStartup	1370	1212	1969	150	1403	1703
			load	1231	1064	1814	141	1270	1541
			domContentLoaded	1231	1064	1814	141	1270	1540
			domInteractive	95	40	203	28	87	95
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	23	16	72	8	24	34
			firstReactRender	22	19	35	3	24	30
			getState	8	3	61	8	7	8
			initialActions	0	0	1	0	0	1
			loadScripts	1209	1048	1791	139	1251	1515
			setupStore	6	4	22	3	6	7
	Webpack	Home	uiStartup	1571	1348	2099	159	1631	1951
			load	1363	1180	1895	152	1431	1747
			domContentLoaded	1362	1180	1895	152	1431	1747
			domInteractive	107	62	179	24	88	98
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	26	17	133	14	26	45
			firstReactRender	34	28	52	5	35	45
			getState	8	4	27	4	7	9
			initialActions	1	0	2	1	1	1
			loadScripts	1339	1160	1873	149	1405	1729
			setupStore	8	5	48	5	7	9

Bundle size diffs

background: 0 Bytes (0%)
ui: 172 Bytes (0%)
common: 0 Bytes (0%)

metamaskbot · 2025-04-02T09:59:13Z

Builds ready [a2ba28d]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

UI Startup Metrics (1182 ± 65 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1182	1060	1407	65	1216	1309
			load	1034	944	1212	61	949	993
			domContentLoaded	1028	936	1203	61	950	996
			domInteractive	16	13	42	5	16	29
			firstPaint	809	133	1212	375	251	995
			backgroundConnect	9	6	28	3	9	10
			firstReactRender	20	15	50	7	19	35
			getState	11	5	26	6	7	8
			initialActions	0	0	1	0	0	0
			loadScripts	818	728	982	60	855	944
			setupStore	7	4	19	3	7	8
	Webpack	Home	uiStartup	2122	1680	2648	238	2262	2566
			load	1648	1306	2137	186	1757	2015
			domContentLoaded	1641	1303	2132	183	1754	1982
			domInteractive	17	12	70	12	14	54
			firstPaint	187	74	410	61	247	78
			backgroundConnect	31	11	276	30	28	78
			firstReactRender	189	62	343	115	85	97
			getState	8	3	21	4	8	9
			initialActions	3	1	5	1	3	4
			loadScripts	1630	1300	2003	174	1750	1929
			setupStore	39	6	286	75	21	8
Firefox	Browserify	Home	uiStartup	1366	1141	1949	152	1387	1760
			load	1229	1029	1796	145	1256	1589
			domContentLoaded	1229	1028	1796	145	1256	1589
			domInteractive	100	39	198	30	87	97
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	24	16	111	12	24	46
			firstReactRender	22	18	110	9	22	26
			getState	7	4	39	5	7	8
			initialActions	0	0	1	0	0	1
			loadScripts	1206	1013	1775	142	1240	1563
			setupStore	6	3	14	2	6	7
	Webpack	Home	uiStartup	1579	1374	2064	151	1619	1981
			load	1360	1182	1821	143	1388	1731
			domContentLoaded	1360	1182	1821	143	1388	1730
			domInteractive	99	61	222	23	90	96
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	27	17	51	6	28	42
			firstReactRender	37	29	60	6	40	52
			getState	9	3	37	6	8	9
			initialActions	0	0	2	1	1	1
			loadScripts	1336	1163	1801	142	1365	1697
			setupStore	9	5	37	4	8	9

Bundle size diffs

background: 0 Bytes (0%)
ui: 172 Bytes (0%)
common: 0 Bytes (0%)

matthewwalsh0 · 2025-04-02T10:11:03Z

...ges/confirmations/components/confirm/info/shared/transaction-details/transaction-details.tsx

@@ -53,13 +56,16 @@ export const RecipientRow = ({ recipient }: { recipient?: Hex } = {}) => {
  const t = useI18nContext();
  const { currentConfirmation } = useConfirmContext<TransactionMeta>();
  const to = recipient ?? currentConfirmation?.txParams?.to;
+  const isBatchTransaction =


Rather than relying on the type, as we may add more batch types in future, should we instead rely on checking the length of nestedTransactions in TransactionMeta?

As that's what triggers the nested transaction data component, plus the metrics.

Perfect, changed to check the length of the nestedTransactions.

matthewwalsh0 · 2025-04-02T10:11:26Z

...ges/confirmations/components/confirm/info/shared/transaction-details/transaction-details.tsx


-  if (!to || !isValidAddress(to)) {
+  if (!to || !isValidAddress(to) || isBatchTransaction) {


Should we be future-proof and also check if to is equal to from?

Just in case we send batch transactions elsewhere in future.

yes, I pushed a fix to check if to is equal to from as well.

metamaskbot · 2025-04-02T11:22:13Z

Builds ready [80b4e52]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

UI Startup Metrics (1240 ± 59 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1240	1136	1398	59	1277	1347
			load	1078	974	1224	61	1185	991
			domContentLoaded	1072	970	1219	60	1177	987
			domInteractive	17	14	37	5	16	31
			firstPaint	808	151	1201	410	210	990
			backgroundConnect	10	7	65	7	9	10
			firstReactRender	19	16	55	5	20	29
			getState	12	4	38	7	6	9
			initialActions	0	0	1	0	0	1
			loadScripts	854	750	1004	61	881	960
			setupStore	8	5	28	4	7	9
	Webpack	Home	uiStartup	2034	1590	2573	243	2215	2480
			load	1591	1274	2072	192	1724	1915
			domContentLoaded	1585	1271	2068	190	1717	1912
			domInteractive	17	12	58	11	13	51
			firstPaint	198	64	609	83	266	83
			backgroundConnect	26	14	80	16	27	72
			firstReactRender	169	54	340	109	85	93
			getState	8	3	20	3	7	9
			initialActions	5	1	262	26	3	4
			loadScripts	1577	1267	2065	188	1706	1893
			setupStore	28	6	292	59	248	9
Firefox	Browserify	Home	uiStartup	1416	1193	2045	176	1471	1861
			load	1269	1079	1865	165	1327	1673
			domContentLoaded	1268	1079	1865	165	1327	1672
			domInteractive	103	43	228	28	86	98
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	25	17	86	9	27	46
			firstReactRender	24	19	56	5	25	31
			getState	7	4	36	4	7	8
			initialActions	0	0	1	0	0	1
			loadScripts	1245	1040	1842	165	1304	1645
			setupStore	6	4	17	2	6	7
	Webpack	Home	uiStartup	1548	1331	2153	181	1603	2003
			load	1335	1152	1895	168	1374	1762
			domContentLoaded	1335	1152	1895	168	1374	1761
			domInteractive	98	40	191	27	88	98
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	25	18	50	6	27	42
			firstReactRender	35	28	50	5	36	45
			getState	8	4	31	5	8	9
			initialActions	0	0	2	1	1	1
			loadScripts	1312	1131	1864	167	1349	1733
			setupStore	7	5	16	1	8	9

Bundle size diffs

background: 0 Bytes (0%)
ui: 141 Bytes (0%)
common: 0 Bytes (0%)

metamaskbot · 2025-04-02T14:08:13Z

Builds ready [16920ca]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

UI Startup Metrics (1211 ± 63 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1211	1066	1475	63	1244	1322
			load	1056	944	1280	59	1151	983
			domContentLoaded	1050	940	1275	58	1181	985
			domInteractive	16	13	35	5	16	28
			firstPaint	734	129	1280	419	229	965
			backgroundConnect	9	7	27	3	9	10
			firstReactRender	18	14	30	3	19	23
			getState	12	4	36	7	6	8
			initialActions	0	0	1	0	0	1
			loadScripts	832	729	1025	56	859	930
			setupStore	8	5	34	3	7	9
	Webpack	Home	uiStartup	2110	1659	2648	255	2277	2574
			load	1648	1308	2054	199	1775	2007
			domContentLoaded	1640	1304	2022	194	1771	1975
			domInteractive	17	12	70	13	14	53
			firstPaint	199	67	605	82	250	92
			backgroundConnect	33	14	340	41	29	78
			firstReactRender	172	56	348	114	90	98
			getState	12	4	263	26	8	9
			initialActions	2	1	5	1	3	4
			loadScripts	1632	1301	1996	190	1760	1950
			setupStore	34	6	268	65	22	8
Firefox	Browserify	Home	uiStartup	1348	1158	1918	141	1404	1698
			load	1215	1040	1752	134	1253	1524
			domContentLoaded	1215	1040	1752	134	1253	1524
			domInteractive	98	39	189	25	90	96
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	22	16	45	5	25	32
			firstReactRender	22	18	52	5	24	30
			getState	6	4	18	2	7	8
			initialActions	0	0	1	0	0	1
			loadScripts	1194	1025	1722	132	1228	1492
			setupStore	6	4	23	3	5	7
	Webpack	Home	uiStartup	1564	1362	2235	170	1623	1994
			load	1349	1168	2008	163	1377	1772
			domContentLoaded	1349	1168	2008	163	1377	1772
			domInteractive	99	43	159	22	91	95
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	25	18	54	6	26	34
			firstReactRender	35	29	54	5	37	44
			getState	9	4	59	7	7	9
			initialActions	0	0	2	1	1	1
			loadScripts	1327	1143	1989	163	1357	1748
			setupStore	8	5	28	4	7	9

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 351 Bytes (0.01%)
ui: 115 Bytes (0%)
common: 0 Bytes (0%)

metamaskbot · 2025-04-04T08:03:33Z

Builds ready [8e7b08c]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1229 ± 68 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1229	1086	1528	68	1268	1358
			load	1080	963	1369	64	1140	990
			domContentLoaded	1075	948	1362	64	1148	993
			domInteractive	17	13	68	8	16	28
			firstPaint	763	77	1243	429	240	957
			backgroundConnect	9	6	31	3	9	10
			firstReactRender	20	15	59	7	20	38
			getState	12	4	29	7	6	9
			initialActions	0	0	1	0	0	1
			loadScripts	825	712	1108	61	862	916
			setupStore	8	5	25	3	7	9
	Webpack	Home	uiStartup	2124	1701	2632	190	2243	2398
			load	1651	1327	2044	144	1755	1854
			domContentLoaded	1645	1320	2014	143	1750	1850
			domInteractive	17	12	73	12	14	48
			firstPaint	170	68	428	66	232	79
			backgroundConnect	27	11	88	14	31	60
			firstReactRender	167	53	353	107	64	96
			getState	12	3	300	29	7	9
			initialActions	3	1	5	1	3	4
			loadScripts	1637	1316	1988	142	1742	1843
			setupStore	45	6	302	81	283	7
Firefox	Browserify	Home	uiStartup	1402	1205	2022	163	1427	1784
			load	1254	1080	1866	158	1285	1621
			domContentLoaded	1253	1079	1865	158	1285	1620
			domInteractive	100	40	195	27	91	98
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	26	17	120	13	25	45
			firstReactRender	24	20	57	6	24	33
			getState	7	4	14	2	7	8
			initialActions	0	0	2	0	0	1
			loadScripts	1229	1062	1765	152	1266	1575
			setupStore	7	4	38	4	6	7
	Webpack	Home	uiStartup	1517	1334	2268	165	1582	1932
			load	1312	1156	2065	152	1357	1692
			domContentLoaded	1312	1155	2065	152	1357	1691
			domInteractive	92	38	185	27	91	97
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	24	18	48	6	25	42
			firstReactRender	35	28	74	6	37	46
			getState	7	4	33	4	7	9
			initialActions	0	0	1	0	1	1
			loadScripts	1290	1137	2046	151	1336	1648
			setupStore	7	5	29	3	7	8

Bundle size diffs

background: 0 Bytes (0%)
ui: 115 Bytes (0%)
common: 0 Bytes (0%)

metamaskbot · 2025-04-07T11:29:35Z

Builds ready [fa8583a]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1267 ± 73 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1267	1103	1408	73	1320	1389
			load	1113	950	1262	76	1179	962
			domContentLoaded	1107	936	1255	76	1183	987
			domInteractive	17	13	58	5	17	27
			firstPaint	855	87	1256	419	176	942
			backgroundConnect	10	6	30	3	9	9
			firstReactRender	21	15	53	7	22	34
			getState	11	4	45	7	6	8
			initialActions	0	0	1	0	0	1
			loadScripts	852	687	1008	73	904	963
			setupStore	8	4	31	3	7	8
	Webpack	Home	uiStartup	2077	1670	2562	199	2210	2346
			load	1611	1301	1984	152	1720	1825
			domContentLoaded	1605	1297	1953	151	1717	1820
			domInteractive	17	12	59	11	14	53
			firstPaint	155	67	370	59	267	92
			backgroundConnect	33	11	347	41	30	63
			firstReactRender	163	53	378	105	79	92
			getState	9	3	19	3	8	9
			initialActions	3	1	5	1	3	4
			loadScripts	1597	1289	1928	149	1712	1808
			setupStore	40	6	296	77	290	8
Firefox	Browserify	Home	uiStartup	1418	1225	2009	156	1470	1806
			load	1270	1094	1822	148	1318	1641
			domContentLoaded	1270	1094	1822	148	1318	1640
			domInteractive	98	39	178	26	86	97
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	26	16	129	13	25	36
			firstReactRender	23	20	51	4	24	30
			getState	7	4	15	2	7	9
			initialActions	0	0	1	0	0	1
			loadScripts	1245	1072	1799	146	1263	1608
			setupStore	6	4	14	2	6	8
	Webpack	Home	uiStartup	1591	1398	2155	167	1657	2005
			load	1374	1202	1948	163	1423	1783
			domContentLoaded	1374	1202	1947	163	1423	1782
			domInteractive	100	43	185	24	91	98
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	24	18	47	6	26	39
			firstReactRender	37	29	55	5	39	47
			getState	8	4	33	6	7	9
			initialActions	1	0	2	1	1	1
			loadScripts	1351	1184	1925	163	1400	1756
			setupStore	8	5	27	4	8	9

Bundle size diffs

background: 0 Bytes (0%)
ui: 115 Bytes (0%)
common: 0 Bytes (0%)

...ges/confirmations/components/confirm/info/shared/transaction-details/transaction-details.tsx

metamaskbot · 2025-04-09T15:03:47Z

Builds ready [42d37af]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

UI Startup Metrics (1669 ± 199 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1669	1314	2156	199	1803	2027
			load	1416	1114	1825	195	1557	1774
			domContentLoaded	1406	1106	1817	195	1551	1758
			domInteractive	25	15	92	14	23	70
			firstPaint	1016	177	1825	575	227	338
			backgroundConnect	15	8	49	7	19	9
			firstReactRender	38	16	295	36	39	66
			getState	21	6	50	11	49	9
			initialActions	0	0	4	1	0	1
			loadScripts	1080	819	1446	174	864	970
			setupStore	13	6	69	9	8	9
	Webpack	Home	uiStartup	2278	1790	2735	185	2377	2592
			load	1827	1409	2259	190	1922	2225
			domContentLoaded	1821	1399	2255	188	1918	2209
			domInteractive	18	12	66	12	15	57
			firstPaint	172	70	332	60	250	84
			backgroundConnect	46	12	356	64	37	61
			firstReactRender	170	54	386	118	63	90
			getState	15	3	301	30	7	9
			initialActions	3	1	7	1	4	5
			loadScripts	1808	1394	2252	181	1896	2176
			setupStore	19	7	184	24	7	8
Firefox	Browserify	Home	uiStartup	1358	1165	1738	115	1433	1580
			load	1219	1050	1592	114	1300	1453
			domContentLoaded	1218	1050	1592	114	1300	1453
			domInteractive	103	39	242	27	86	98
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	24	16	132	13	24	34
			firstReactRender	22	18	40	4	22	29
			getState	7	4	35	4	7	8
			initialActions	0	0	1	0	0	1
			loadScripts	1196	1035	1572	114	1281	1438
			setupStore	7	3	36	5	6	7
	Webpack	Home	uiStartup	1526	1347	1897	114	1588	1782
			load	1317	1158	1654	108	1370	1535
			domContentLoaded	1317	1158	1654	108	1370	1534
			domInteractive	94	34	191	25	88	97
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	25	18	62	7	26	41
			firstReactRender	34	28	52	5	37	45
			getState	8	4	29	5	7	9
			initialActions	1	0	2	1	1	1
			loadScripts	1294	1142	1630	107	1343	1510
			setupStore	8	5	31	4	8	9

metamaskbot · 2025-04-10T05:53:26Z

Builds ready [dfc52c0]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

UI Startup Metrics (1219 ± 57 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1219	1107	1401	57	1251	1318
			load	1061	934	1216	60	1142	985
			domContentLoaded	1056	927	1209	59	1166	991
			domInteractive	17	13	69	9	16	32
			firstPaint	705	78	1180	431	249	976
			backgroundConnect	6	4	13	1	7	8
			firstReactRender	22	15	76	10	22	43
			getState	14	5	45	9	7	9
			initialActions	0	0	1	0	0	1
			loadScripts	813	687	965	58	852	897
			setupStore	8	4	23	3	7	9
	Webpack	Home	uiStartup	2151	1728	2590	179	2271	2448
			load	1726	1313	2238	172	1783	2063
			domContentLoaded	1720	1307	2230	171	1776	2058
			domInteractive	16	12	60	10	14	46
			firstPaint	175	64	469	68	252	77
			backgroundConnect	29	9	235	31	33	63
			firstReactRender	145	53	346	102	60	92
			getState	11	3	45	7	6	9
			initialActions	3	1	5	1	3	4
			loadScripts	1715	1305	2212	168	1773	2029
			setupStore	27	6	329	52	7	9
Firefox	Browserify	Home	uiStartup	1334	1171	1806	108	1389	1572
			load	1196	1044	1639	107	1254	1379
			domContentLoaded	1196	1044	1638	107	1254	1379
			domInteractive	98	39	196	28	89	96
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	19	13	47	7	19	30
			firstReactRender	22	18	58	6	22	29
			getState	7	3	34	3	7	8
			initialActions	0	0	1	0	0	1
			loadScripts	1180	1029	1621	107	1239	1362
			setupStore	6	3	36	5	6	7
	Webpack	Home	uiStartup	1577	1382	2034	133	1656	1868
			load	1356	1188	1793	122	1432	1624
			domContentLoaded	1356	1188	1792	122	1432	1623
			domInteractive	96	37	199	24	89	97
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	25	16	310	29	23	38
			firstReactRender	36	28	51	5	38	47
			getState	10	5	47	7	8	9
			initialActions	1	0	2	1	1	1
			loadScripts	1336	1170	1773	122	1414	1594
			setupStore	9	5	63	7	8	9

vinistevam added the team-confirmations Push issues to confirmations team label Apr 2, 2025

vinistevam marked this pull request as ready for review April 2, 2025 09:09

vinistevam requested a review from a team as a code owner April 2, 2025 09:09

matthewwalsh0 requested changes Apr 2, 2025

View reviewed changes

vinistevam added 3 commits April 2, 2025 12:57

fix: Hide "interacting with" row for batch transaction

5d6dd37

fix: check nestedTransactions

cee65f3

fix: apply suggestions

16920ca

vinistevam force-pushed the fix/hide-recipient-row-tx-batch-type branch from 80b4e52 to 16920ca Compare April 2, 2025 13:28

Merge branch 'main' into fix/hide-recipient-row-tx-batch-type

8e7b08c

vinistevam added 2 commits April 7, 2025 05:56

Merge branch 'main' into fix/hide-recipient-row-tx-batch-type

8b9578f

Merge branch 'main' into fix/hide-recipient-row-tx-batch-type

fa8583a

matthewwalsh0 previously approved these changes Apr 8, 2025

View reviewed changes

...ges/confirmations/components/confirm/info/shared/transaction-details/transaction-details.tsx Outdated Show resolved Hide resolved

vinistevam changed the title ~~fix: Hide "interacting with" row for batch transaction~~ fix: Display "🦊 Smart contract" in "interacting with" row for batch transaction confirmations Apr 9, 2025

fix: display fox smart contract batch transaction

2fc30c0

vinistevam dismissed matthewwalsh0’s stale review via 2fc30c0 April 9, 2025 05:19

Merge branch 'main' into fix/hide-recipient-row-tx-batch-type

42d37af

vinistevam force-pushed the fix/hide-recipient-row-tx-batch-type branch from deec64b to 42d37af Compare April 9, 2025 14:14

vinistevam added 4 commits April 9, 2025 16:22

Merge branch 'main' into fix/hide-recipient-row-tx-batch-type

d27b733

Merge branch 'main' into fix/hide-recipient-row-tx-batch-type

4c5950b

Merge branch 'main' into fix/hide-recipient-row-tx-batch-type

21e3167

Merge branch 'main' into fix/hide-recipient-row-tx-batch-type

dfc52c0

jpuri approved these changes Apr 10, 2025

View reviewed changes

OGPoyraz approved these changes Apr 10, 2025

View reviewed changes

matthewwalsh0 approved these changes Apr 10, 2025

View reviewed changes

vinistevam added this pull request to the merge queue Apr 10, 2025

Merged via the queue into main with commit b9ef23e Apr 10, 2025
166 checks passed

vinistevam deleted the fix/hide-recipient-row-tx-batch-type branch April 10, 2025 14:06

github-actions bot locked and limited conversation to collaborators Apr 10, 2025

metamaskbot added the release-12.17.0 Issue or pull request that will be included in release 12.17.0 label Apr 10, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Display "🦊 Smart contract" in "interacting with" row for batch transaction confirmations #31507

fix: Display "🦊 Smart contract" in "interacting with" row for batch transaction confirmations #31507

vinistevam commented Apr 2, 2025 •

edited

Loading

github-actions bot commented Apr 2, 2025

metamaskbot commented Apr 2, 2025

metamaskbot commented Apr 2, 2025

metamaskbot commented Apr 2, 2025

matthewwalsh0 Apr 2, 2025

vinistevam Apr 7, 2025

matthewwalsh0 Apr 2, 2025

vinistevam Apr 7, 2025

metamaskbot commented Apr 2, 2025

metamaskbot commented Apr 2, 2025

metamaskbot commented Apr 4, 2025

metamaskbot commented Apr 7, 2025

metamaskbot commented Apr 9, 2025

metamaskbot commented Apr 10, 2025


		if (!to \|\| !isValidAddress(to)) {
		if (!to \|\| !isValidAddress(to) \|\| isBatchTransaction) {

fix: Display "🦊 Smart contract" in "interacting with" row for batch transaction confirmations #31507

fix: Display "🦊 Smart contract" in "interacting with" row for batch transaction confirmations #31507

Conversation

vinistevam commented Apr 2, 2025 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Apr 2, 2025

metamaskbot commented Apr 2, 2025

✨ Files requiring CODEOWNER review ✨

metamaskbot commented Apr 2, 2025

metamaskbot commented Apr 2, 2025

matthewwalsh0 Apr 2, 2025

Choose a reason for hiding this comment

vinistevam Apr 7, 2025

Choose a reason for hiding this comment

matthewwalsh0 Apr 2, 2025

Choose a reason for hiding this comment

vinistevam Apr 7, 2025

Choose a reason for hiding this comment

metamaskbot commented Apr 2, 2025

metamaskbot commented Apr 2, 2025

metamaskbot commented Apr 4, 2025

metamaskbot commented Apr 7, 2025

metamaskbot commented Apr 9, 2025

metamaskbot commented Apr 10, 2025

vinistevam commented Apr 2, 2025 •

edited

Loading