fix: apply suggestions

Author: vinistevam

test/data/confirmations/contract-interaction.ts

@@ -33,7 +33,6 @@ export const genUnapprovedContractInteractionConfirmation = ({
   simulationData,
   gasFeeTokens,
   selectedGasFeeToken,
-  type = TransactionType.contractInteraction,
 }: {
   address?: Hex;
   authorizationList?: AuthorizationList;
@@ -43,7 +42,6 @@ export const genUnapprovedContractInteractionConfirmation = ({
   gasFeeTokens?: GasFeeToken[];
   selectedGasFeeToken?: Hex;
   simulationData?: SimulationData;
-  type?: TransactionType;
 } = {}): Confirmation => {
   const confirmation: Confirmation = {
     actionId: String(400855682),
@@ -180,7 +178,7 @@ export const genUnapprovedContractInteractionConfirmation = ({
       value: '0x3782dace9d900000',
     },
     gasLimitNoBuffer: '0xab77',
-    type,
+    type: TransactionType.contractInteraction,
     userEditedGasLimit: false,
     userFeeLevel: 'medium',
     verifiedOnBlockchain: false,

ui/pages/confirmations/components/confirm/info/shared/transaction-details/transaction-details.test.tsx

@@ -3,7 +3,10 @@ import configureMockStore from 'redux-mock-store';
 import thunk from 'redux-thunk';
 import { Hex } from '@metamask/utils';
 import { toHex } from '@metamask/controller-utils';
-import { TransactionType } from '@metamask/transaction-controller';
+import {
+  NestedTransactionMetadata,
+  TransactionType,
+} from '@metamask/transaction-controller';
 import {
   getMockConfirmState,
   getMockConfirmStateForTransaction,
@@ -179,8 +182,22 @@ describe('<TransactionDetails />', () => {
 
   describe('RecipientRow', () => {
     it('should not be displayed when the transaction is a batch transaction', () => {
+      const ADDRESS_MOCK = '0x88aa6343307ec9a652ccddda3646e62b2f1a5125';
+      const ADDRESS_2_MOCK = '0x1234567890123456789012345678901234567891';
       const contractInteraction = genUnapprovedContractInteractionConfirmation({
-        type: TransactionType.batch,
+        address: ADDRESS_MOCK,
+        nestedTransactions: [
+          {
+            to: ADDRESS_MOCK,
+            data: '0x1',
+            type: TransactionType.contractInteraction,
+          },
+          {
+            to: ADDRESS_2_MOCK,
+            data: '0x2',
+            type: TransactionType.contractInteraction,
+          },
+        ] as NestedTransactionMetadata[],
       });
       const state = getMockConfirmStateForTransaction(contractInteraction, {
         metamask: {

ui/pages/confirmations/components/confirm/info/shared/transaction-details/transaction-details.tsx

@@ -1,7 +1,4 @@
-import {
-  TransactionMeta,
-  TransactionType,
-} from '@metamask/transaction-controller';
+import { TransactionMeta } from '@metamask/transaction-controller';
 import { isValidAddress } from 'ethereumjs-util';
 import React, { useMemo } from 'react';
 import { useSelector } from 'react-redux';
@@ -57,8 +54,7 @@ export const RecipientRow = ({ recipient }: { recipient?: Hex } = {}) => {
   const { currentConfirmation } = useConfirmContext<TransactionMeta>();
   const { from } = currentConfirmation?.txParams ?? {};
   const to = recipient ?? currentConfirmation?.txParams?.to;
-
-  const { nestedTransactions } = currentConfirmation;
+  const { nestedTransactions } = currentConfirmation ?? {};
   const isBatch = Boolean(nestedTransactions?.length) && to === from;
 
   if (!to || !isValidAddress(to) || isBatch) {