Skip to content

feat(remote-mode): add feature slide #31463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 8, 2025
Merged

feat(remote-mode): add feature slide #31463

merged 6 commits into from
Apr 8, 2025

Conversation

matallui
Copy link
Contributor

@matallui matallui commented Apr 1, 2025

Description

Add Remote Mode's feature slide, as that is the entry point for the feature.
Some changes had to be made to the slides logic to accommodate this, but the main breaking change was to the way updateSlides works.

updateSlides used to append new slides to the end of the existing ones, then recently got changed to prepend new slides to the beginning of the array. With these changes, updateSlides does indeed perform a full update to the existing slides (i.e., it will replace the existing slides). However, if any of the new slides matches an existing one, a merge is performed, thus maintaining previous properties (e.g., dismissed).

Open in GitHub Codespaces

Related issues

Fixes: #31271

Manual testing steps

  1. Set vaultRemoteMode: false (feature flag), and verify that slide is not present
  2. Set vaultRemoteMode: true (feature flag), and verify that slide is present
  3. Test different scenarios to validate slide order
  4. Dismiss slides and make sure their dismissal is persistent

Screenshots/Recordings

Before

Screen.Recording.2025-04-01.at.9.33.19.AM.mov

After

Screen.Recording.2025-04-01.at.9.34.24.AM.mov

Tests

Screenshot 2025-03-31 at 8 31 41 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Apr 1, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

✨ Files requiring CODEOWNER review ✨

🖥️ @MetaMask/wallet-ux

  • ui/components/multichain/account-overview/account-overview-layout.tsx

@matallui matallui added the team-vault MetaMask Vault Team label Apr 1, 2025
@matallui matallui requested review from kevinbluer and caieu April 1, 2025 15:39
@metamaskbot
Copy link
Collaborator

Builds ready [7b63ecb]
UI Startup Metrics (1237 ± 88 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1237109915268812891405
load10819541345821199988
domContentLoaded10759501340821192991
domInteractive17133641629
firstPaint7091361245430237974
backgroundConnect106304910
firstReactRender19155051931
getState11432678
initialActions001000
loadScripts856739110879893958
setupStore7525279
WebpackHomeuiStartup1004799137385970995
load84360598975894950
domContentLoaded83759198576889946
domInteractive15124471432
firstPaint32557939320805923
backgroundConnect18135791647
firstReactRender1712160151625
getState5219358
initialActions001000
loadScripts83558198376888945
setupStore7525379
FirefoxBrowserifyHomeuiStartup13521173191014313821702
load12091048175813312521542
domContentLoaded12091048175813312521541
domInteractive9540210249097
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2416104122444
firstReactRender22193632228
getState7334479
initialActions001001
loadScripts11871032172813212311510
setupStore6436368
WebpackHomeuiStartup10138541648167920977
load8837501418145830945
domContentLoaded8837491418145830945
domInteractive114352052714392
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2213119152332
firstReactRender19163032027
getState104791089
initialActions001001
loadScripts8657351396142822969
setupStore8552779
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: -73 Bytes (0%)
  • ui: 534 Bytes (0.01%)
  • common: 144 Bytes (0%)

@matallui matallui marked this pull request as ready for review April 1, 2025 19:10
@matallui matallui requested a review from a team as a code owner April 1, 2025 19:10
@metamaskbot
Copy link
Collaborator

Builds ready [30b5c7a]
UI Startup Metrics (1240 ± 67 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1240111714896712731375
load10829691301621134996
domContentLoaded10769661294611166997
domInteractive17134951628
firstPaint7611291302431187262
backgroundConnect106546910
firstReactRender18143631923
getState12534878
initialActions001001
loadScripts823710103562845938
setupStore8519278
WebpackHomeuiStartup21531729274419722932397
load16741316208517317731999
domContentLoaded16691312206117217681991
domInteractive181290131449
firstPaint161713585823477
backgroundConnect291189143653
firstReactRender177533741095790
getState11434668
initialActions317146
loadScripts16611308203617017621969
setupStore24641549328
FirefoxBrowserifyHomeuiStartup13661184192316213981766
load12201058176015512551628
domContentLoaded12201058175915512551628
domInteractive9840180229398
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect3017170222952
firstReactRender23195052331
getState7427379
initialActions001001
loadScripts11921038173215112351578
setupStore942292369
WebpackHomeuiStartup15171319208015815511912
load13121144186414813401685
domContentLoaded13121143186314813401685
domInteractive9538170218896
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect24175162635
firstReactRender35285463946
getState8435689
initialActions002111
loadScripts12901118184014713191663
setupStore8551689
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: -73 Bytes (0%)
  • ui: 534 Bytes (0.01%)
  • common: 144 Bytes (0%)

Copy link
Contributor

@vinnyhoward vinnyhoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and tested this PR. Code changes look good and all functionality works as expected. Approved.

@matallui matallui added this pull request to the merge queue Apr 8, 2025
Merged via the queue into main with commit 945e2cb Apr 8, 2025
164 checks passed
@matallui matallui deleted the vault/remote-mode-slide branch April 8, 2025 20:57
@github-actions github-actions bot locked and limited conversation to collaborators Apr 8, 2025
@metamaskbot metamaskbot added the release-12.17.0 Issue or pull request that will be included in release 12.17.0 label Apr 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.17.0 Issue or pull request that will be included in release 12.17.0 team-vault MetaMask Vault Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remote Mode banner
4 participants