-
Notifications
You must be signed in to change notification settings - Fork 5.2k
feat(remote-mode): add feature slide #31463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
✨ Files requiring CODEOWNER review ✨🖥️ @MetaMask/wallet-ux
|
Builds ready [7b63ecb]
UI Startup Metrics (1237 ± 88 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
caieu
approved these changes
Apr 1, 2025
Builds ready [30b5c7a]
UI Startup Metrics (1240 ± 67 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
vinnyhoward
approved these changes
Apr 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed and tested this PR. Code changes look good and all functionality works as expected. Approved.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
release-12.17.0
Issue or pull request that will be included in release 12.17.0
team-vault
MetaMask Vault Team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add Remote Mode's feature slide, as that is the entry point for the feature.
Some changes had to be made to the slides logic to accommodate this, but the main breaking change was to the way
updateSlides
works.updateSlides
used to append new slides to the end of the existing ones, then recently got changed to prepend new slides to the beginning of the array. With these changes,updateSlides
does indeed perform a full update to the existing slides (i.e., it will replace the existing slides). However, if any of the new slides matches an existing one, a merge is performed, thus maintaining previous properties (e.g.,dismissed
).Related issues
Fixes: #31271
Manual testing steps
vaultRemoteMode: false
(feature flag), and verify that slide is not presentvaultRemoteMode: true
(feature flag), and verify that slide is presentScreenshots/Recordings
Before
Screen.Recording.2025-04-01.at.9.33.19.AM.mov
After
Screen.Recording.2025-04-01.at.9.34.24.AM.mov
Tests
Pre-merge author checklist
Pre-merge reviewer checklist