Remote Mode banner #31271
Assignees
Labels
INVALID-ISSUE-TEMPLATE
Issue's body doesn't match any issue template.
release-12.17.0
Issue or pull request that will be included in release 12.17.0
team-vault
MetaMask Vault Team
Comments
metamaskbot
added
the
INVALID-ISSUE-TEMPLATE
7 tasks
github-merge-queue bot
pushed a commit
that referenced
this issue
Apr 8, 2025
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> Add Remote Mode's feature slide, as that is the entry point for the feature. Some changes had to be made to the slides logic to accommodate this, but the main breaking change was to the way `updateSlides` works. `updateSlides` used to append new slides to the end of the existing ones, then [recently got changed](#31246) to prepend new slides to the beginning of the array. With these changes, `updateSlides` does indeed perform a full update to the existing slides (i.e., it will replace the existing slides). However, if any of the new slides matches an existing one, a merge is performed, thus maintaining previous properties (e.g., `dismissed`). [](https://codespaces.new/MetaMask/metamask-extension/pull/31463?quickstart=1) ## **Related issues** Fixes: #31271 ## **Manual testing steps** 1. Set `vaultRemoteMode: false` (feature flag), and verify that slide is not present 2. Set `vaultRemoteMode: true` (feature flag), and verify that slide is present 3. Test different scenarios to validate slide order 4. Dismiss slides and make sure their dismissal is persistent ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> https://github.com/user-attachments/assets/e5f48e98-588b-4f08-aaf9-10e594a1e498 ### **After** <!-- [screenshots/recordings] --> https://github.com/user-attachments/assets/af33e944-89b0-4ec4-b2bc-c4e5f5ba8b7c ### **Tests** <img width="768" alt="Screenshot 2025-03-31 at 8 31 41 PM" src="https://github.com/user-attachments/assets/15b49e92-64ed-4408-875f-de3634183fdb" /> ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
](https://codespaces.new/MetaMask/metamask-extension/pull/31463?quickstart=1){kind=link}
metamaskbot
added
the
release-12.17.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What
Show users the "Remote Mode" feature banner, when the following conditions are met:
signEip7702Authorization()How
The text was updated successfully, but these errors were encountered: