feat(solana): update add account from opt in solana #31387

PatrykLucka · 2025-03-28T10:23:29Z

Description

This PR updates the flow of adding new Solana account from the Whats new modal to be consistent with the flow from accounts picker. It also allows user to pick which SRP to use if there are more than one SRP added.

Related issues

Depends on: #31358

Manual testing steps

Install new MetaMask instance and onboard
Whats new modal should be displayed automatically
Click Create Solana account
New modal should be displayed

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-03-28T10:23:39Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2025-03-28T10:25:13Z

✨ Files requiring CODEOWNER review ✨

🖥️ @MetaMask/wallet-ux

ui/components/multichain/create-solana-account-modal/create-solana-account-modal.tsx
ui/components/multichain/create-solana-account-modal/index.ts

metamaskbot · 2025-03-31T10:58:41Z

Builds ready [dd50ee7]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

UI Startup Metrics (1209 ± 62 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1209	1084	1430	62	1250	1313
			load	1054	955	1309	62	1155	987
			domContentLoaded	1048	950	1299	61	1155	983
			domInteractive	16	13	37	4	16	29
			firstPaint	731	82	1311	416	247	979
			backgroundConnect	10	7	22	3	9	10
			firstReactRender	19	16	44	5	19	34
			getState	11	4	31	7	6	8
			initialActions	0	0	1	0	0	1
			loadScripts	828	737	1062	58	862	928
			setupStore	8	5	17	2	7	9
	Webpack	Home	uiStartup	947	779	1213	79	954	975
			load	807	653	937	57	839	891
			domContentLoaded	800	636	925	57	833	879
			domInteractive	15	12	42	7	13	36
			firstPaint	489	54	884	333	831	878
			backgroundConnect	16	10	66	9	15	38
			firstReactRender	14	12	29	4	14	26
			getState	6	4	14	2	7	8
			initialActions	0	0	1	0	0	1
			loadScripts	798	634	915	57	832	869
			setupStore	7	4	12	1	8	8
Firefox	Browserify	Home	uiStartup	1394	1189	1943	165	1433	1843
			load	1252	1065	1808	158	1301	1681
			domContentLoaded	1252	1065	1807	158	1300	1681
			domInteractive	101	38	264	32	90	97
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	23	16	55	6	24	34
			firstReactRender	22	19	37	3	24	29
			getState	7	4	46	6	7	8
			initialActions	0	0	1	0	0	1
			loadScripts	1230	1043	1788	157	1281	1652
			setupStore	6	4	13	2	6	8
	Webpack	Home	uiStartup	975	822	1644	169	898	973
			load	855	718	1412	147	805	964
			domContentLoaded	855	718	1412	147	805	964
			domInteractive	112	34	221	28	167	97
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	20	13	89	11	22	36
			firstReactRender	18	16	29	2	19	23
			getState	10	4	85	13	7	9
			initialActions	0	0	1	0	0	1
			loadScripts	839	704	1396	144	794	949
			setupStore	8	5	75	8	7	9

Bundle size diffs [🚀 Bundle size reduced!]

background: -634.11 KiB (-9.77%)
ui: -969.88 KiB (-12.51%)
common: -806.36 KiB (-7.85%)

ulissesferreira · 2025-04-02T16:03:18Z

ui/components/app/whats-new-modal/whats-new-modal.tsx

+            handleModalClose();
+          }}
+        />
+      )}


Why is this in parallel with the normal notifications Modal?

Well it technically is a part of the flow from the notification modal, but I didn't want to use the notification modal itself, as it's a bit limited in terms of the structure (header, content and footer) and it was easier to add it next to it and just hide notification when user decides to add new account.

ui/components/multichain/network-list-menu/index.scss

aganglada · 2025-04-02T16:02:30Z

ui/components/multichain/network-list-menu/add-non-evm-account/add-non-evm-account.tsx

+const SNAP_CLIENT_CONFIG_MAP: Record<
+  string,
+  { clientType: WalletClientType | null; chainId: CaipChainId | null }
+> = {
+  [MultichainNetworks.BITCOIN]: {
+    clientType: WalletClientType.Bitcoin,
+    chainId: MultichainNetworks.BITCOIN,
+  },
+  [MultichainNetworks.BITCOIN_TESTNET]: {
+    clientType: WalletClientType.Bitcoin,
+    chainId: MultichainNetworks.BITCOIN_TESTNET,
+  },
+  [MultichainNetworks.SOLANA]: {
+    clientType: WalletClientType.Solana,
+    chainId: MultichainNetworks.SOLANA,
+  },
+};


I've seen this before somewhere

It's a similar map, but is using network instead of action (used in account menu) as a key

aganglada · 2025-04-02T16:04:05Z

ui/components/multichain/create-solana-account-modal/create-solana-account-modal.tsx

@@ -0,0 +1,107 @@
+import React from 'react';


Doesnt this already exist as create-snap-account?

Actually this one is using create-snap-account, it's just a modal that uses it, it was needed as we don't have modal open, as we had in case of network or account modal flow.

metamaskbot · 2025-04-03T11:05:32Z

Builds ready [0e253f6]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

UI Startup Metrics (1220 ± 51 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1220	1120	1342	51	1259	1310
			load	1069	975	1187	49	1126	990
			domContentLoaded	1063	971	1181	49	1125	988
			domInteractive	16	13	46	5	16	29
			firstPaint	752	129	1185	418	215	991
			backgroundConnect	10	6	60	6	9	10
			firstReactRender	19	15	70	6	19	26
			getState	11	4	32	7	6	7
			initialActions	0	0	1	0	0	1
			loadScripts	812	715	921	47	845	888
			setupStore	8	4	21	3	7	8
	Webpack	Home	uiStartup	2098	1686	2606	223	2235	2424
			load	1634	1328	2169	188	1751	1976
			domContentLoaded	1629	1324	2164	186	1746	1969
			domInteractive	18	12	67	12	14	54
			firstPaint	219	66	1757	174	267	75
			backgroundConnect	28	12	281	29	28	66
			firstReactRender	179	56	362	117	87	95
			getState	8	3	22	4	8	9
			initialActions	3	1	6	1	3	4
			loadScripts	1616	1321	1973	172	1741	1916
			setupStore	29	6	291	61	288	9
Firefox	Browserify	Home	uiStartup	1386	1180	1844	141	1419	1763
			load	1248	1056	1671	135	1278	1601
			domContentLoaded	1248	1056	1671	135	1278	1600
			domInteractive	101	41	238	30	87	96
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	26	16	155	18	25	44
			firstReactRender	22	19	44	3	22	28
			getState	7	3	35	4	7	8
			initialActions	0	0	1	0	0	1
			loadScripts	1224	1038	1643	134	1253	1571
			setupStore	6	4	13	2	6	7
	Webpack	Home	uiStartup	1504	1322	2298	170	1555	1843
			load	1302	1152	2075	158	1344	1624
			domContentLoaded	1301	1151	2075	158	1344	1624
			domInteractive	90	38	173	21	89	96
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	25	17	49	7	26	43
			firstReactRender	34	28	56	5	36	45
			getState	8	4	65	7	7	8
			initialActions	0	0	2	1	1	1
			loadScripts	1279	1134	2051	157	1316	1595
			setupStore	7	5	28	3	7	9

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0%)
ui: 6.52 KiB (0.1%)
common: 1 Bytes (0%)

NidhiKJha

LGTM!
What's new modal shows up ✅
User able to add Solana account from Modal ✅

metamaskbot · 2025-04-04T16:48:23Z

Builds ready [b668f1b]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1220 ± 53 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1220	1106	1333	53	1254	1310
			load	1074	969	1174	49	1131	989
			domContentLoaded	1068	965	1170	49	1127	990
			domInteractive	17	13	73	9	16	30
			firstPaint	804	72	1176	407	186	72
			backgroundConnect	9	6	29	4	9	10
			firstReactRender	19	15	33	4	20	29
			getState	10	4	35	7	6	8
			initialActions	0	0	1	0	0	1
			loadScripts	818	722	922	48	857	893
			setupStore	8	4	27	3	7	8
	Webpack	Home	uiStartup	2176	1776	2495	163	2286	2373
			load	1689	1389	2030	131	1777	1876
			domContentLoaded	1682	1385	1918	128	1773	1872
			domInteractive	17	13	65	11	14	47
			firstPaint	165	65	415	67	271	91
			backgroundConnect	32	11	175	20	37	63
			firstReactRender	193	54	362	112	64	95
			getState	13	3	252	24	7	9
			initialActions	3	1	5	1	4	5
			loadScripts	1672	1382	1905	128	1768	1856
			setupStore	40	6	306	68	284	7
Firefox	Browserify	Home	uiStartup	1367	1190	2039	155	1392	1712
			load	1225	1052	1881	146	1249	1548
			domContentLoaded	1225	1052	1881	146	1249	1547
			domInteractive	96	41	181	24	91	97
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	24	16	147	15	23	50
			firstReactRender	23	18	36	3	25	29
			getState	6	3	17	2	7	8
			initialActions	0	0	1	0	0	1
			loadScripts	1202	1033	1864	141	1228	1514
			setupStore	6	4	23	2	6	7
	Webpack	Home	uiStartup	1598	1351	2072	159	1676	1948
			load	1377	1150	1836	150	1443	1731
			domContentLoaded	1377	1150	1836	150	1443	1731
			domInteractive	97	36	178	21	89	97
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	25	19	50	5	28	32
			firstReactRender	37	29	55	6	40	49
			getState	8	4	41	6	7	9
			initialActions	1	0	2	1	1	1
			loadScripts	1353	1130	1816	150	1419	1703
			setupStore	8	5	37	4	8	9

Bundle size diffs [🚀 Bundle size reduced!]

background: -74 Bytes (0%)
ui: 2.77 KiB (0.04%)
common: 0 Bytes (0%)

darkwing · 2025-04-07T14:41:44Z

ui/components/app/whats-new-modal/whats-new-modal.tsx

-    </Modal>
+    <>
+      <Modal
+        onClose={() => null}


Why is this null? Do we not want to allow the user to close this via the x?

We do, but it's done with:

<modal.header.component onClose={onClose} image={image} />

I changed it to null, because it was also triggered by some other flow, where we didn't want to close it yet.

metamaskbot · 2025-04-08T18:13:16Z

Builds ready [b9a1540]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1289 ± 62 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1289	1148	1435	62	1322	1405
			load	1125	976	1262	65	1171	984
			domContentLoaded	1117	970	1250	65	1165	978
			domInteractive	18	14	65	8	17	32
			firstPaint	801	145	1259	438	230	291
			backgroundConnect	12	7	89	12	9	10
			firstReactRender	25	14	163	21	23	41
			getState	15	5	40	8	7	9
			initialActions	0	0	1	0	0	1
			loadScripts	852	713	990	65	893	972
			setupStore	9	5	31	4	7	9
	Webpack	Home	uiStartup	2662	2038	3068	208	2794	2980
			load	2266	1558	2755	292	2514	2639
			domContentLoaded	2257	1554	2751	290	2507	2635
			domInteractive	20	14	105	14	17	53
			firstPaint	187	69	449	72	270	86
			backgroundConnect	44	13	459	73	31	74
			firstReactRender	96	55	476	86	64	74
			getState	14	4	183	26	6	8
			initialActions	2	1	8	1	2	5
			loadScripts	2242	1550	2747	292	2501	2624
			setupStore	17	7	307	35	8	9
Firefox	Browserify	Home	uiStartup	1327	1163	1865	142	1350	1634
			load	1190	1046	1729	136	1225	1502
			domContentLoaded	1190	1046	1729	136	1225	1502
			domInteractive	95	36	204	29	88	96
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	24	16	55	7	26	40
			firstReactRender	22	18	51	5	22	31
			getState	7	3	34	4	7	8
			initialActions	0	0	1	0	0	1
			loadScripts	1168	1024	1694	135	1203	1484
			setupStore	6	4	24	3	6	7
	Webpack	Home	uiStartup	1516	1340	1838	111	1600	1720
			load	1306	1159	1610	104	1388	1495
			domContentLoaded	1306	1159	1610	104	1387	1494
			domInteractive	99	67	167	23	88	98
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	25	18	57	6	28	36
			firstReactRender	35	28	60	6	38	47
			getState	8	5	28	4	8	9
			initialActions	1	0	2	1	1	1
			loadScripts	1283	1139	1582	104	1357	1471
			setupStore	10	5	292	28	8	9

PatrykLucka self-assigned this Mar 28, 2025

metamaskbot added the team-mmi PRs from the MMI team label Mar 28, 2025

PatrykLucka force-pushed the MMMULTISRP-115-update-add-account-from-opt-in-solana branch 3 times, most recently from 579925b to dd50ee7 Compare March 31, 2025 10:21

PatrykLucka changed the title ~~Mmmultisrp 115 update add account from opt in solana~~ feat(solana): update add account from opt in solana Mar 31, 2025

PatrykLucka marked this pull request as ready for review March 31, 2025 11:11

PatrykLucka requested a review from a team as a code owner March 31, 2025 11:11

ulissesferreira reviewed Apr 2, 2025

View reviewed changes

aganglada reviewed Apr 2, 2025

View reviewed changes

PatrykLucka force-pushed the MMMULTISRP-115-update-add-account-from-opt-in-solana branch 2 times, most recently from 41f898d to 0e253f6 Compare April 3, 2025 10:28

zone-live previously approved these changes Apr 3, 2025

View reviewed changes

PatrykLucka enabled auto-merge April 3, 2025 14:13

NidhiKJha previously approved these changes Apr 4, 2025

View reviewed changes

PatrykLucka added this pull request to the merge queue Apr 4, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 4, 2025

PatrykLucka added this pull request to the merge queue Apr 4, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 4, 2025

PatrykLucka dismissed stale reviews from NidhiKJha and zone-live via b668f1b April 4, 2025 16:08

PatrykLucka force-pushed the MMMULTISRP-115-update-add-account-from-opt-in-solana branch from 0e253f6 to b668f1b Compare April 4, 2025 16:08

PatrykLucka enabled auto-merge April 4, 2025 16:55

zone-live previously approved these changes Apr 7, 2025

View reviewed changes

darkwing reviewed Apr 7, 2025

View reviewed changes

PatrykLucka requested a review from darkwing April 7, 2025 14:54

feat(solana): update add account flow from whats new notification

1179450

PatrykLucka dismissed zone-live’s stale review via 7c104c0 April 8, 2025 16:30

PatrykLucka force-pushed the MMMULTISRP-115-update-add-account-from-opt-in-solana branch from b668f1b to 7c104c0 Compare April 8, 2025 16:30

fix: unit test fix

b9a1540

PatrykLucka force-pushed the MMMULTISRP-115-update-add-account-from-opt-in-solana branch from 7c104c0 to b9a1540 Compare April 8, 2025 17:31

zone-live approved these changes Apr 9, 2025

View reviewed changes

NidhiKJha approved these changes Apr 9, 2025

View reviewed changes

PatrykLucka added this pull request to the merge queue Apr 9, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 9, 2025

PatrykLucka added this pull request to the merge queue Apr 9, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 9, 2025

PatrykLucka added this pull request to the merge queue Apr 9, 2025

Merged via the queue into main with commit 0bb08ab Apr 9, 2025
166 checks passed

PatrykLucka deleted the MMMULTISRP-115-update-add-account-from-opt-in-solana branch April 9, 2025 12:33

github-actions bot locked and limited conversation to collaborators Apr 9, 2025

metamaskbot added the release-12.17.0 Issue or pull request that will be included in release 12.17.0 label Apr 9, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(solana): update add account from opt in solana #31387

feat(solana): update add account from opt in solana #31387

PatrykLucka commented Mar 28, 2025 •

edited

Loading

github-actions bot commented Mar 28, 2025

metamaskbot commented Mar 28, 2025 •

edited

Loading

metamaskbot commented Mar 31, 2025

ulissesferreira Apr 2, 2025

PatrykLucka Apr 3, 2025

aganglada Apr 2, 2025

PatrykLucka Apr 3, 2025

aganglada Apr 2, 2025

PatrykLucka Apr 3, 2025

metamaskbot commented Apr 3, 2025

NidhiKJha left a comment

metamaskbot commented Apr 4, 2025

darkwing Apr 7, 2025

PatrykLucka Apr 7, 2025

metamaskbot commented Apr 8, 2025

feat(solana): update add account from opt in solana #31387

feat(solana): update add account from opt in solana #31387

Conversation

PatrykLucka commented Mar 28, 2025 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Mar 28, 2025

metamaskbot commented Mar 28, 2025 • edited Loading

✨ Files requiring CODEOWNER review ✨

metamaskbot commented Mar 31, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

metamaskbot commented Apr 3, 2025

NidhiKJha left a comment

Choose a reason for hiding this comment

metamaskbot commented Apr 4, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

metamaskbot commented Apr 8, 2025

PatrykLucka commented Mar 28, 2025 •

edited

Loading

metamaskbot commented Mar 28, 2025 •

edited

Loading