feat(solana): update add account from network picker #31358

PatrykLucka · 2025-03-27T15:19:36Z

Description

This PR updates the flow of adding new Solana account from the network picker to be consistent with the flow from accounts picker. It also allows user to pick which SRP to use if there are more than one SRP added.

Related issues

Manual testing steps

Make sure you do not have Solana accounts
Open network picker
Click Solana
Click Add Account

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-03-27T15:19:50Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2025-03-28T09:14:44Z

✨ Files requiring CODEOWNER review ✨

🖥️ @MetaMask/wallet-ux

ui/components/multichain/create-account/create-account.tsx
ui/components/multichain/network-list-menu/add-non-evm-account/add-non-evm-account.tsx
ui/components/multichain/network-list-menu/index.scss
ui/components/multichain/network-list-menu/network-list-menu.tsx

metamaskbot · 2025-03-28T10:23:19Z

Builds ready [374ae53]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

UI Startup Metrics (1173 ± 56 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1173	1063	1353	56	1208	1267
			load	1022	927	1178	52	949	993
			domContentLoaded	1016	919	1169	52	946	996
			domInteractive	16	12	37	4	15	27
			firstPaint	788	131	1171	374	268	993
			backgroundConnect	9	6	28	3	8	10
			firstReactRender	20	15	49	7	20	38
			getState	11	5	30	6	7	9
			initialActions	0	0	1	0	0	1
			loadScripts	806	714	954	50	834	898
			setupStore	7	5	21	2	7	8
	Webpack	Home	uiStartup	940	762	1298	88	942	967
			load	802	647	957	62	834	895
			domContentLoaded	796	642	938	61	826	891
			domInteractive	15	12	43	7	13	36
			firstPaint	478	60	946	338	83	893
			backgroundConnect	16	10	50	8	14	37
			firstReactRender	14	12	28	4	13	26
			getState	6	3	11	1	7	7
			initialActions	0	0	1	0	0	1
			loadScripts	794	641	925	60	824	890
			setupStore	7	5	14	2	7	9
Firefox	Browserify	Home	uiStartup	1389	1188	1853	151	1429	1784
			load	1249	1065	1690	142	1297	1617
			domContentLoaded	1249	1065	1690	142	1297	1617
			domInteractive	97	39	189	26	90	96
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	26	17	123	17	25	47
			firstReactRender	23	19	44	4	25	29
			getState	7	4	51	5	7	9
			initialActions	0	0	1	0	0	1
			loadScripts	1224	1047	1667	136	1276	1554
			setupStore	6	4	12	2	6	7
	Webpack	Home	uiStartup	989	834	1640	180	889	977
			load	869	728	1404	159	801	896
			domContentLoaded	868	728	1404	159	801	896
			domInteractive	123	43	209	24	144	92
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	20	13	106	14	20	32
			firstReactRender	18	16	27	2	18	25
			getState	8	4	60	7	7	8
			initialActions	0	0	1	0	0	1
			loadScripts	852	714	1383	155	814	887
			setupStore	9	4	100	11	7	8

Bundle size diffs [🚀 Bundle size reduced!]

background: -572.99 KiB (-8.83%)
ui: -975.3 KiB (-12.58%)
common: -875.09 KiB (-8.52%)

ui/components/multichain/network-list-menu/add-non-evm-account/add-non-evm-account.tsx

ui/components/multichain/network-list-menu/index.scss

metamaskbot · 2025-03-31T15:02:14Z

Builds ready [27a2c81]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

UI Startup Metrics (1189 ± 57 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1189	1076	1376	57	1228	1294
			load	1035	948	1202	52	957	993
			domContentLoaded	1030	943	1198	52	955	994
			domInteractive	16	13	38	5	16	27
			firstPaint	739	150	1202	389	268	994
			backgroundConnect	9	6	33	4	9	10
			firstReactRender	19	15	43	5	20	29
			getState	11	4	39	7	6	9
			initialActions	0	0	1	0	0	1
			loadScripts	815	723	978	51	847	894
			setupStore	7	4	18	2	7	8
	Webpack	Home	uiStartup	918	778	1171	77	944	964
			load	778	594	1008	69	826	885
			domContentLoaded	772	584	1004	69	818	882
			domInteractive	15	12	46	7	13	33
			firstPaint	424	69	1007	330	820	839
			backgroundConnect	16	11	50	8	15	39
			firstReactRender	14	12	28	3	13	24
			getState	6	4	15	2	6	8
			initialActions	0	0	1	0	0	1
			loadScripts	769	574	994	69	817	877
			setupStore	7	5	14	2	7	9
Firefox	Browserify	Home	uiStartup	1370	1147	1976	168	1421	1786
			load	1232	1034	1796	160	1269	1625
			domContentLoaded	1232	1033	1796	160	1269	1625
			domInteractive	98	39	189	27	89	97
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	25	16	157	15	26	35
			firstReactRender	22	19	48	4	23	30
			getState	7	3	37	4	7	8
			initialActions	0	0	1	0	0	1
			loadScripts	1209	1018	1703	154	1255	1597
			setupStore	6	4	18	2	6	7
	Webpack	Home	uiStartup	984	850	1489	140	901	959
			load	863	730	1344	129	808	970
			domContentLoaded	862	729	1344	129	807	970
			domInteractive	123	32	213	31	145	46
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	20	13	62	8	23	39
			firstReactRender	19	17	36	3	19	25
			getState	8	3	49	5	8	9
			initialActions	0	0	1	0	0	1
			loadScripts	845	715	1316	125	799	964
			setupStore	8	4	56	7	8	9

Bundle size diffs [🚀 Bundle size reduced!]

background: -634.13 KiB (-9.77%)
ui: -971.48 KiB (-12.53%)
common: -801.58 KiB (-7.8%)

metamaskbot · 2025-04-01T09:46:32Z

Builds ready [1049b9f]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1215 ± 67 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1215	1068	1388	67	1274	1322
			load	1063	947	1227	62	1146	980
			domContentLoaded	1057	933	1222	62	1164	995
			domInteractive	16	13	33	4	16	29
			firstPaint	758	150	1228	414	246	970
			backgroundConnect	10	6	29	4	9	10
			firstReactRender	18	15	40	3	19	22
			getState	11	4	32	7	6	8
			initialActions	0	0	1	0	0	1
			loadScripts	840	723	983	60	890	933
			setupStore	7	4	20	2	7	8
	Webpack	Home	uiStartup	969	781	1179	86	948	976
			load	817	564	935	78	876	920
			domContentLoaded	811	557	932	78	869	913
			domInteractive	15	12	38	6	13	33
			firstPaint	293	53	920	288	813	920
			backgroundConnect	17	13	48	8	16	39
			firstReactRender	17	12	29	4	17	28
			getState	6	3	19	3	5	8
			initialActions	0	0	1	0	0	0
			loadScripts	808	554	930	78	868	911
			setupStore	7	4	15	2	6	8
Firefox	Browserify	Home	uiStartup	1396	1236	1988	156	1439	1797
			load	1258	1073	1843	150	1304	1635
			domContentLoaded	1258	1073	1843	150	1304	1635
			domInteractive	103	39	226	30	86	97
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	23	17	50	5	25	32
			firstReactRender	23	19	49	5	25	33
			getState	6	4	22	2	7	8
			initialActions	0	0	1	0	0	1
			loadScripts	1236	1054	1804	147	1285	1612
			setupStore	6	4	24	3	6	7
	Webpack	Home	uiStartup	991	828	1509	169	893	940
			load	867	729	1323	149	812	925
			domContentLoaded	867	728	1323	149	812	925
			domInteractive	115	41	192	26	163	96
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	19	13	34	5	22	32
			firstReactRender	18	16	28	2	19	23
			getState	10	4	88	13	8	9
			initialActions	0	0	1	0	0	1
			loadScripts	850	715	1307	146	826	975
			setupStore	8	5	62	8	7	8

Bundle size diffs

background: 0 Bytes (0%)
ui: 10.89 KiB (0.16%)
common: 0 Bytes (0%)

PatrykLucka self-assigned this Mar 27, 2025

metamaskbot added the team-mmi PRs from the MMI team label Mar 27, 2025

PatrykLucka force-pushed the MMMULTISRP-114-update-add-account-from-network-picker branch 2 times, most recently from 92ca851 to a04c137 Compare March 28, 2025 09:12

PatrykLucka force-pushed the MMMULTISRP-114-update-add-account-from-network-picker branch from a04c137 to 374ae53 Compare March 28, 2025 09:45

PatrykLucka marked this pull request as ready for review March 28, 2025 11:13

PatrykLucka requested a review from a team as a code owner March 28, 2025 11:13

shane-t previously approved these changes Mar 28, 2025

View reviewed changes

PatrykLucka mentioned this pull request Mar 31, 2025

feat(solana): update add account from opt in solana #31387

Merged

7 tasks