Skip to content

fix (cherry-pick): simulation of type-4 transactions (#31335) #31336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2025

Conversation

matthewwalsh0
Copy link
Member

@matthewwalsh0 matthewwalsh0 commented Mar 26, 2025

Description

Cherry-pick of #31335 for 12.15.0.

Using patch as @metamask/transaction-controller includes unrelated changes.

Open in GitHub Codespaces

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@matthewwalsh0 matthewwalsh0 added the team-confirmations Push issues to confirmations team label Mar 26, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [1a2aa6f]
Page Load Metrics (3229 ± 1464 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint170815128303628331360
domContentLoaded159114492277227311311
load173616146322930491464
domInteractive2872410015072
backgroundConnect801377437387186
firstReactRender20340877235
getState2579117918991
initialActions01000
loadScripts118213136213225441221
setupStore11309818943
uiStartup202217674513438181833

@matthewwalsh0 matthewwalsh0 merged commit 535f847 into Version-v12.15.0 Mar 27, 2025
75 checks passed
@matthewwalsh0 matthewwalsh0 deleted the cherry-pick/type-4-simulation branch March 27, 2025 09:52
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants