Skip to content

fix: simulation of type-4 transactions #31335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 31, 2025
Merged

Conversation

matthewwalsh0
Copy link
Member

@matthewwalsh0 matthewwalsh0 commented Mar 26, 2025

Description

Fix balance change simulation of type-4 transactions by bumping @metamask/transaction-controller to 52.3.0.

Open in GitHub Codespaces

Related issues

Fixes: #4506

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link

socket-security bot commented Mar 26, 2025

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/[email protected]52.3.0 None 0 2.68 MB metamaskbot

View full report↗︎

matthewwalsh0 added a commit that referenced this pull request Mar 27, 2025
## **Description**

Cherry-pick of #31335 for `12.15.0`.

Using patch as `@metamask/transaction-controller` includes unrelated
changes.

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/31336?quickstart=1)

## **Related issues**

## **Manual testing steps**

## **Screenshots/Recordings**

### **Before**

### **After**

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@matthewwalsh0 matthewwalsh0 force-pushed the fix/type-4-simulation branch from 80c66e4 to 71317e4 Compare March 31, 2025 08:57
vinistevam
vinistevam previously approved these changes Mar 31, 2025
OGPoyraz
OGPoyraz previously approved these changes Mar 31, 2025
@matthewwalsh0 matthewwalsh0 enabled auto-merge March 31, 2025 09:12
@metamaskbot
Copy link
Collaborator

Builds ready [dc89e0b]
UI Startup Metrics (1193 ± 54 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1193109314185412221296
load10369191187481127978
domContentLoaded1030913117848913980
domInteractive16132841627
firstPaint7391311186399248975
backgroundConnect105485910
firstReactRender20145872039
getState12433768
initialActions003001
loadScripts81269894848842894
setupStore7414278
WebpackHomeuiStartup905798116376928951
load76558890767814885
domContentLoaded76057190168810874
domInteractive15113861334
firstPaint34551895303710828
backgroundConnect15115291339
firstReactRender14122831324
getState6412277
initialActions001001
loadScripts75856189968808864
setupStore7413278
FirefoxBrowserifyHomeuiStartup13661177197015414051749
load12281054182214512711570
domContentLoaded12281054182114512701569
domInteractive9639199259098
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2416105112531
firstReactRender22194532527
getState6427378
initialActions001001
loadScripts12051036180014412501543
setupStore6443567
WebpackHomeuiStartup9688231619159892973
load8497181383141828945
domContentLoaded8487171382141828957
domInteractive116351872414397
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect1913115121931
firstReactRender18162521824
getState8462979
initialActions002001
loadScripts8327051357137815942
setupStore8553678
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 1.96 KiB (0.03%)
  • ui: -7 Bytes (0%)
  • common: 4.78 KiB (0.05%)

@matthewwalsh0 matthewwalsh0 added this pull request to the merge queue Mar 31, 2025
Merged via the queue into main with commit 1bb5fae Mar 31, 2025
148 checks passed
@matthewwalsh0 matthewwalsh0 deleted the fix/type-4-simulation branch March 31, 2025 11:33
@github-actions github-actions bot locked and limited conversation to collaborators Mar 31, 2025
@metamaskbot metamaskbot added the release-12.17.0 Issue or pull request that will be included in release 12.17.0 label Mar 31, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.17.0 Issue or pull request that will be included in release 12.17.0 team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants