-
Notifications
You must be signed in to change notification settings - Fork 5.2k
fix: display network switch notification for bridge screen #31037
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
@vinistevam would this switch notification continue to appear when there is no 'actual' network switch? I believe there is benefit in giving the user feedback of the network that they will interact with based on the token selection also in the case of having no global network. I ask because Wallet UX is working on removing the GNS and I'd like to understand if this toast will remain visible. |
@hesterbruikman |
Builds ready [cdeddc6]
Page Load Metrics (3558 ± 1106 ms)
Bundle size diffs
|
Description
This PR aims to display the network switch notification when users try to bridge a token on a network other than the current selected one, informing the user that a switch network hanppended.
Related issues
Fixes: #30925
Manual testing steps
Screenshots/Recordings
switch-notification.webm
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist