Skip to content

[Bug]: Network switch notification is not displayed for Bridge transactions #30925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sleepytanya opened this issue Mar 12, 2025 · 0 comments · Fixed by #31037
Closed

[Bug]: Network switch notification is not displayed for Bridge transactions #30925

sleepytanya opened this issue Mar 12, 2025 · 0 comments · Fixed by #31037
Assignees
Labels
needs-triage Issue needs to be triaged regression-prod-12.10.4 Regression bug that was found in production in release 12.10.4 release-12.16.0 Issue or pull request that will be included in release 12.16.0 Sev2-normal Normal severity; minor loss of service or inconvenience. team-confirmations Push issues to confirmations team type-bug Something isn't working

Comments

@sleepytanya
Copy link
Contributor

Describe the bug

Currently, the network switch notification for Bridge transactions appears briefly, making it almost imperceptible, in scenarios where the user does not proceed with the selecting recipient / fetching quotes.
It seems that this notification may not be displayed at all once the destination network is selected.

Expected behavior

Full visibility and correct timing for network switch notifications

Screenshots/Recordings

Screen.Recording.2025-03-12.at.00.43.01.mov

Steps to reproduce

  1. Enable Popular networks view
  2. Select token on a network other that the currently selected one
  3. Start Bridge

Error messages or log output

Detection stage

In production (default)

Version

12.10.4

Build type

None

Browser

Chrome, Firefox

Operating system

MacOS

Hardware wallet

No response

Additional context

No response

Severity

No response

@sleepytanya sleepytanya added regression-prod-12.10.4 Regression bug that was found in production in release 12.10.4 Sev2-normal Normal severity; minor loss of service or inconvenience. team-confirmations Push issues to confirmations team type-bug Something isn't working labels Mar 12, 2025
@github-project-automation github-project-automation bot moved this to To be triaged in Bugs by team Mar 12, 2025
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by severity Mar 12, 2025
@metamaskbot metamaskbot added the needs-triage Issue needs to be triaged label Mar 12, 2025
@vinistevam vinistevam self-assigned this Mar 13, 2025
github-merge-queue bot pushed a commit that referenced this issue Mar 21, 2025
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**
This PR aims to display the network switch notification when users try
to bridge a token on a network other than the current selected one,
informing the user that a switch network hanppended.

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/31037?quickstart=1)

## **Related issues**

Fixes: #30925

## **Manual testing steps**

1. Enable Popular network view
2. Select a token on a network other than the current selected one
3. Start Bridge

## **Screenshots/Recordings**


[switch-notification.webm](https://github.com/user-attachments/assets/97285855-7d8a-419c-ae80-874e5f7c76b5)

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@metamaskbot metamaskbot added the release-12.16.0 Issue or pull request that will be included in release 12.16.0 label Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-triage Issue needs to be triaged regression-prod-12.10.4 Regression bug that was found in production in release 12.10.4 release-12.16.0 Issue or pull request that will be included in release 12.16.0 Sev2-normal Normal severity; minor loss of service or inconvenience. team-confirmations Push issues to confirmations team type-bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants