Skip to content

fix(30348): profile sync can now be searched in settings #30687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 4, 2025
Merged

fix(30348): profile sync can now be searched in settings #30687

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bacd0e4
fix: profile sync can now be searched in settings
vinnyhoward Mar 3, 2025
2fb94fa
fix: update seach tests
vinnyhoward Mar 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions ui/helpers/constants/settings.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,13 +330,22 @@ const SETTINGS_CONSTANTS = [
route: `${SECURITY_ROUTE}#dataCollectionForMarketing`,
icon: 'fa fa-lock',
},
// securityAndPrivacy settingsRefs[20]
{
tabMessage: (t) => t('securityAndPrivacy'),
sectionMessage: (t) => t('deleteMetaMetricsData'),
descriptionMessage: (t) => t('deleteMetaMetricsDataDescription'),
route: `${SECURITY_ROUTE}#delete-metametrics-data`,
icon: 'fa fa-lock',
},
// securityAndPrivacy settingsRefs[21]
{
tabMessage: (t) => t('securityAndPrivacy'),
sectionMessage: (t) => t('profileSync'),
descriptionMessage: (t) => t('profileSyncDescription'),
route: `${SECURITY_ROUTE}#profile-sync`,
icon: 'fa fa-lock',
},
{
tabMessage: (t) => t('networks'),
sectionMessage: (t) => t('mainnet'),
Expand Down
2 changes: 1 addition & 1 deletion ui/helpers/utils/settings-search.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ describe('Settings Search Utils', () => {
it('returns "Security & privacy" section count', () => {
expect(
getNumberOfSettingRoutesInTab(t, t('securityAndPrivacy')),
).toStrictEqual(21);
).toStrictEqual(22);
});

it('returns "Network" section count', () => {
Expand Down
1 change: 1 addition & 0 deletions ui/pages/settings/security-tab/__snapshots__/security-tab.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,7 @@ exports[`Security Tab should match snapshot 1`] = `
</span>
<div
class="settings-page__content-padded"
data-testid="profile-sync"
>
<div
class="mm-box"
Expand Down
6 changes: 5 additions & 1 deletion ui/pages/settings/security-tab/security-tab.component.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1163,7 +1163,11 @@ export default class SecurityTab extends PureComponent {
{this.context.t('privacy')}
</span>

<div className="settings-page__content-padded">
<div
ref={this.settingsRefs[21]}
className="settings-page__content-padded"
data-testid="profile-sync"
>
<ProfileSyncToggle />
</div>

Expand Down
Loading