Skip to content

fix(30348): profile sync can now be searched in settings #30687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 4, 2025

Conversation

vinnyhoward
Copy link
Contributor

@vinnyhoward vinnyhoward commented Mar 3, 2025

Description

Issue: Profile sync cannot be searched within our settings

Solution: Added necessary logic to support search for profile settings

Open in GitHub Codespaces

Related issues

Fixes: #30348

Manual testing steps

  1. Go to settings page
  2. Search Profile Sync
  3. Test different variations of the word profile sync

Screenshots/Recordings

search

Before After
before_welcome after_welcome

Before

NA

After

NA

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Mar 3, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [2fb94fa]
Page Load Metrics (1657 ± 52 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint14651893165711053
domContentLoaded14591862162910751
load14641872165710852
domInteractive20132453014
backgroundConnect976312010
firstReactRender1477302110
getState55619188
initialActions01000
loadScripts1092136512077938
setupStore763212010
uiStartup17132175188712158
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 239 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@DDDDDanica
Copy link
Contributor

LGTM !

@github-project-automation github-project-automation bot moved this from Needs dev review to Review finalised - Ready to be merged in PR review queue Mar 4, 2025
@vinnyhoward vinnyhoward added this pull request to the merge queue Mar 4, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Mar 4, 2025
@vinnyhoward vinnyhoward added this pull request to the merge queue Mar 4, 2025
Merged via the queue into main with commit f2fca58 Mar 4, 2025
79 checks passed
@vinnyhoward vinnyhoward deleted the fix-30348-profile-sync-settings-search branch March 4, 2025 21:38
@github-project-automation github-project-automation bot moved this from Review finalised - Ready to be merged to Merged, Closed or Archived in PR review queue Mar 4, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Mar 4, 2025
@metamaskbot metamaskbot added the release-12.15.0 Issue or pull request that will be included in release 12.15.0 label Mar 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.15.0 Issue or pull request that will be included in release 12.15.0 team-wallet-ux
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Bug]: Profile sync option can't be found using search in the Settings
4 participants