-
Notifications
You must be signed in to change notification settings - Fork 5.2k
fix(25182): reloading page during SRP creation breaks flow #30178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…low and the user refreshes the page, they lose their SRP
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [d697706]
Page Load Metrics (1858 ± 120 ms)
Bundle size diffs
|
Builds ready [b03f532]
Page Load Metrics (1666 ± 59 ms)
Bundle size diffs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work!
…x-25182-reloading-page-loses-srp
Builds ready [3d3cc68]
Page Load Metrics (2086 ± 222 ms)
Bundle size diffs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Builds ready [6b28089]
|
Builds ready [d08d319]
Page Load Metrics (1736 ± 111 ms)
Bundle size diffs
|
Description
Problem
Fixed an issue in the onboarding flow where refreshing the page during the Secret Recovery Phrase (SRP) confirmation step would result in a broken UI state. The solution redirects users to the unlock screen when SRP is needed but not available, retrieves the phrase after password verification, and returns them to their previous location in the flow. This ensures a smooth recovery from page refreshes during the onboarding process.
The Solution
Related issues
Fixes: #25182
Manual testing steps
Screenshots/Recordings
Before
before.mov
After
after.mov
Pre-merge author checklist
Pre-merge reviewer checklist