Merge branch 'main' into fix-25182-reloading-page-loses-srp

Author: vinnyhoward

development/circular-deps.jsonc

@@ -12,10 +12,6 @@
     "ui/components/app/alert-system/confirm-alert-modal/index.tsx",
     "ui/pages/confirmations/components/confirm/footer/footer.tsx"
   ],
-  [
-    "ui/components/app/name/name-details/name-details.tsx",
-    "ui/components/app/name/name.tsx"
-  ],
   [
     "ui/components/multichain/pages/send/components/account-picker.tsx",
     "ui/components/multichain/pages/send/components/index.ts"

ui/components/app/confirm/info/row/__snapshots__/address.test.tsx.snap

@@ -289,7 +289,7 @@ exports[`ConfirmInfoRowAddress renders appropriately with PetNames enabled 1`] =
       class="mm-box mm-box--display-flex"
     >
       <div
-        class="name name__missing"
+        class="name name__clickable name__missing"
       >
         <span
           class="mm-box name__icon mm-icon mm-icon--size-md mm-box--display-inline-block mm-box--color-inherit"

ui/components/app/name/__snapshots__/name.test.tsx.snap

@@ -6,7 +6,7 @@ exports[`Name renders address with image 1`] = `
     class="mm-box mm-box--display-flex"
   >
     <div
-      class="name name__saved"
+      class="name name__clickable name__saved"
     >
       <img
         alt=""
@@ -30,7 +30,7 @@ exports[`Name renders address with long saved name 1`] = `
     class="mm-box mm-box--display-flex"
   >
     <div
-      class="name name__saved"
+      class="name name__clickable name__saved"
     >
       <div
         class=""
@@ -92,7 +92,7 @@ exports[`Name renders address with no saved name 1`] = `
     class="mm-box mm-box--display-flex"
   >
     <div
-      class="name name__missing"
+      class="name name__clickable name__missing"
     >
       <span
         class="mm-box name__icon mm-icon mm-icon--size-md mm-box--display-inline-block mm-box--color-inherit"
@@ -114,7 +114,7 @@ exports[`Name renders address with saved name 1`] = `
     class="mm-box mm-box--display-flex"
   >
     <div
-      class="name name__saved"
+      class="name name__clickable name__saved"
     >
       <div
         class=""
@@ -176,7 +176,7 @@ exports[`Name renders when no address value is passed 1`] = `
     class="mm-box mm-box--display-flex"
   >
     <div
-      class="name name__missing"
+      class="name name__clickable name__missing"
     >
       <span
         class="mm-box name__icon mm-icon mm-icon--size-md mm-box--display-inline-block mm-box--color-inherit"

ui/components/app/name/index.scss

@@ -6,7 +6,10 @@
   gap: 5px;
   font-size: 12px;
   max-width: 100%;
-  cursor: pointer;
+
+  &__clickable {
+    cursor: pointer;
+  }
 
   &__missing {
     background-color: var(--color-background-alternative);