Skip to content

fix: Readd cancel and speed up transaction modal #30093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 4, 2025
Merged

Conversation

pedronfigueiredo
Copy link
Contributor

@pedronfigueiredo pedronfigueiredo commented Feb 4, 2025

Description

On #29884, a lot of code related to MetaMask Institutional was removed.

The <CancelSpeedupPopover /> component was removed, probably because it was conditionally rendered when a custodian was not present (for non-MMI code only), and someone mechanically removing code might have thought it wasn't needed anymore. What we wanted to do instead was to remove the condition and render the modal unconditionally.

This PR reintroduces the component.

Screenshot 2025-02-04 at 11 35 57

Open in GitHub Codespaces

Related issues

Fixes: #30027

Manual testing steps

  1. Submit a transaction with low gas parameters
  2. Once it is pending, speed up or cancel it from the activity list

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@pedronfigueiredo pedronfigueiredo added the team-confirmations Push issues to confirmations team label Feb 4, 2025
@pedronfigueiredo pedronfigueiredo self-assigned this Feb 4, 2025
Copy link
Contributor

github-actions bot commented Feb 4, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [1c19f71]
Page Load Metrics (1606 ± 37 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1451179216017436
domContentLoaded1443174915767235
load1447179216067737
domInteractive16105372311
backgroundConnect98331199
firstReactRender1676382512
getState45015157
initialActions01000
loadScripts1035132911386632
setupStore85413136
uiStartup17012188183210852
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 18.83 KiB (0.24%)
  • common: 0 Bytes (0.00%)

@pedronfigueiredo pedronfigueiredo added this pull request to the merge queue Feb 4, 2025
Merged via the queue into main with commit 775eddc Feb 4, 2025
76 checks passed
@pedronfigueiredo pedronfigueiredo deleted the pnf/30027 branch February 4, 2025 13:41
@github-actions github-actions bot locked and limited conversation to collaborators Feb 4, 2025
@metamaskbot metamaskbot added the release-12.13.0 Issue or pull request that will be included in release 12.13.0 label Feb 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.13.0 Issue or pull request that will be included in release 12.13.0 team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: [Bug]: Unable to Cancel or Speed Up a transaction
4 participants