[Bug]: [Bug]: Unable to Cancel or Speed Up a transaction #30027
Assignees
Labels
regression-RC-12.12.0
Regression bug that was found in release candidate (RC) for release 12.12.0
release-12.13.0
Issue or pull request that will be included in release 12.13.0
release-blocker
This bug is blocking the next release
Sev1-high
High severity; partial loss of service with severe impact upon users, with no workaround.
team-confirmations
Push issues to confirmations team
type-bug
Something isn't working
Comments
sleepytanya
added
regression-RC-12.12.0
7 tasks
7 tasks
github-merge-queue bot
pushed a commit
that referenced
this issue
Feb 4, 2025
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> On #29884, a lot of code related to MetaMask Institutional was removed. The `<CancelSpeedupPopover />` component was removed, probably because it was conditionally rendered when a custodian was not present (for non-MMI code only), and someone mechanically removing code might have thought it wasn't needed anymore. What we wanted to do instead was to remove the condition and render the modal unconditionally. This PR reintroduces the component. <img width="837" alt="Screenshot 2025-02-04 at 11 35 57" src="https://github.com/user-attachments/assets/f74ebbbc-98b2-4115-b3a3-210fb58c0b7c" /> [](https://codespaces.new/MetaMask/metamask-extension/pull/30093?quickstart=1) ## **Related issues** Fixes: #30027 ## **Manual testing steps** 1. Submit a transaction with low gas parameters 2. Once it is pending, speed up or cancel it from the activity list ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
pedronfigueiredo
added a commit
that referenced
this issue
Feb 4, 2025
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> On #29884, a lot of code related to MetaMask Institutional was removed. The `<CancelSpeedupPopover />` component was removed, probably because it was conditionally rendered when a custodian was not present (for non-MMI code only), and someone mechanically removing code might have thought it wasn't needed anymore. What we wanted to do instead was to remove the condition and render the modal unconditionally. This PR reintroduces the component. <img width="837" alt="Screenshot 2025-02-04 at 11 35 57" src="https://github.com/user-attachments/assets/f74ebbbc-98b2-4115-b3a3-210fb58c0b7c" /> [](https://codespaces.new/MetaMask/metamask-extension/pull/30093?quickstart=1) ## **Related issues** Fixes: #30027 ## **Manual testing steps** 1. Submit a transaction with low gas parameters 2. Once it is pending, speed up or cancel it from the activity list ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
14 tasks
metamaskbot
added
the
release-12.13.0
14 tasks
itsyoboieltr
pushed a commit
that referenced
this issue
Feb 5, 2025
#30100) cherry-picks: #30093 <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> On #29884, a lot of code related to MetaMask Institutional was removed. The `<CancelSpeedupPopover />` component was removed, probably because it was conditionally rendered when a custodian was not present (for non-MMI code only), and someone mechanically removing code might have thought it wasn't needed anymore. What we wanted to do instead was to remove the condition and render the modal unconditionally. This PR reintroduces the component. <img width="837" alt="Screenshot 2025-02-04 at 11 35 57" src="https://github.com/user-attachments/assets/f74ebbbc-98b2-4115-b3a3-210fb58c0b7c" /> [](https://codespaces.new/MetaMask/metamask-extension/pull/30093?quickstart=1) ## **Related issues** Fixes: #30027 ## **Manual testing steps** 1. Submit a transaction with low gas parameters 2. Once it is pending, speed up or cancel it from the activity list ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> [](https://codespaces.new/MetaMask/metamask-extension/pull/30100?quickstart=1) ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
davidmurdoch
pushed a commit
that referenced
this issue
Feb 5, 2025
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> On #29884, a lot of code related to MetaMask Institutional was removed. The `<CancelSpeedupPopover />` component was removed, probably because it was conditionally rendered when a custodian was not present (for non-MMI code only), and someone mechanically removing code might have thought it wasn't needed anymore. What we wanted to do instead was to remove the condition and render the modal unconditionally. This PR reintroduces the component. <img width="837" alt="Screenshot 2025-02-04 at 11 35 57" src="https://github.com/user-attachments/assets/f74ebbbc-98b2-4115-b3a3-210fb58c0b7c" /> [](https://codespaces.new/MetaMask/metamask-extension/pull/30093?quickstart=1) ## **Related issues** Fixes: #30027 ## **Manual testing steps** 1. Submit a transaction with low gas parameters 2. Once it is pending, speed up or cancel it from the activity list ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
davidmurdoch
pushed a commit
that referenced
this issue
Feb 5, 2025
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> On #29884, a lot of code related to MetaMask Institutional was removed. The `<CancelSpeedupPopover />` component was removed, probably because it was conditionally rendered when a custodian was not present (for non-MMI code only), and someone mechanically removing code might have thought it wasn't needed anymore. What we wanted to do instead was to remove the condition and render the modal unconditionally. This PR reintroduces the component. <img width="837" alt="Screenshot 2025-02-04 at 11 35 57" src="https://github.com/user-attachments/assets/f74ebbbc-98b2-4115-b3a3-210fb58c0b7c" /> [](https://codespaces.new/MetaMask/metamask-extension/pull/30093?quickstart=1) ## **Related issues** Fixes: #30027 ## **Manual testing steps** 1. Submit a transaction with low gas parameters 2. Once it is pending, speed up or cancel it from the activity list ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
seaona
pushed a commit
that referenced
this issue
Feb 6, 2025
](https://codespaces.new/MetaMask/metamask-extension/pull/30093?quickstart=1){kind=link}
](https://codespaces.new/MetaMask/metamask-extension/pull/30100?quickstart=1){kind=link}
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> On #29884, a lot of code related to MetaMask Institutional was removed. The `<CancelSpeedupPopover />` component was removed, probably because it was conditionally rendered when a custodian was not present (for non-MMI code only), and someone mechanically removing code might have thought it wasn't needed anymore. What we wanted to do instead was to remove the condition and render the modal unconditionally. This PR reintroduces the component. <img width="837" alt="Screenshot 2025-02-04 at 11 35 57" src="https://github.com/user-attachments/assets/f74ebbbc-98b2-4115-b3a3-210fb58c0b7c" /> [](https://codespaces.new/MetaMask/metamask-extension/pull/30093?quickstart=1) ## **Related issues** Fixes: #30027 ## **Manual testing steps** 1. Submit a transaction with low gas parameters 2. Once it is pending, speed up or cancel it from the activity list ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
and others
Describe the bug
The "Cancel" and "Speed Up" buttons do not trigger any action when clicked, present on all networks
Expected behavior
Speed UpandCancelshould work as expectedScreenshots/Recordings
Screen.Recording.2025-01-31.at.01.47.28.mov
Steps to reproduce
Error messages or log output
Detection stage
During release testing
Version
12.12.0
Build type
None
Browser
Chrome
Operating system
MacOS
Hardware wallet
No response
Additional context
No response
Severity
No response
The text was updated successfully, but these errors were encountered: