-
Notifications
You must be signed in to change notification settings - Fork 5.2k
fix: Makes NFT list properly wrap within the send modal #30036
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
danjm
approved these changes
Jan 31, 2025
So, the resulting CSS will be: .nft-items__wrapper {
grid-template-columns: repeat(4, minmax(120px, 1fr));
}
.mm-modal-content .nft-items__wrapper {
grid-template-columns: repeat(2, minmax(120px, 1fr));
} What It Does:
Sorry couldn't not chime in on a pure SCSS change lol |
itsyoboieltr
approved these changes
Jan 31, 2025
Builds ready [b8489b6]
Page Load Metrics (1727 ± 103 ms)
Bundle size diffs
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
release-12.13.0
Issue or pull request that will be included in release 12.13.0
team-extension-platform
Extension Platform team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Wraps the NFT list within the Send flow such that it will not overflow
Related issues
Fixes: #29974
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist