[Bug]: [Bug]: In the NFT view within the Send flow, the token assets are displayed only partially #29974
Assignees
Labels
regression-RC-12.11.0
Regression bug that was found in release candidate (RC) for release 12.11.0
release-12.13.0
Issue or pull request that will be included in release 12.13.0
release-blocker
This bug is blocking the next release
team-assets
team-wallet-ux
type-bug
Something isn't working
Comments
sleepytanya
added
regression-RC-12.11.0
darkwing
added a commit
to darkwing/metamask-extension
that referenced
this issue
Jan 30, 2025
7 tasks
darkwing
added a commit
that referenced
this issue
Jan 30, 2025
7 tasks
github-merge-queue bot
pushed a commit
that referenced
this issue
Jan 31, 2025
## **Description** - This is a non-fork mirror of @darkwing's PR: #30005 Wraps the NFT list within the Send flow such that it will not overflow [](https://codespaces.new/MetaMask/metamask-extension/pull/30005?quickstart=1) ## **Related issues** Fixes: #29974 ## **Manual testing steps** 1. Use an account with many NFTs 2. Start send flow 3. Click the AssetPicker, choose NFTs 4. See the wrapped NFTs ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <img width="521" alt="SCR-20250130-hbwm" src="https://github.com/user-attachments/assets/abeb3b78-be50-4aa4-841f-f8441ba4103f" /> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. Co-authored-by: David Walsh <[email protected]>
](https://codespaces.new/MetaMask/metamask-extension/pull/30005?quickstart=1){kind=link}
metamaskbot
added
the
release-12.13.0
dbrans
added a commit
that referenced
this issue
Jan 31, 2025
## **Description** - This is a non-fork mirror of @darkwing's PR: #30005 Wraps the NFT list within the Send flow such that it will not overflow [](https://codespaces.new/MetaMask/metamask-extension/pull/30005?quickstart=1) ## **Related issues** Fixes: #29974 ## **Manual testing steps** 1. Use an account with many NFTs 2. Start send flow 3. Click the AssetPicker, choose NFTs 4. See the wrapped NFTs ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <img width="521" alt="SCR-20250130-hbwm" src="https://github.com/user-attachments/assets/abeb3b78-be50-4aa4-841f-f8441ba4103f" /> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. Co-authored-by: David Walsh <[email protected]>
14 tasks
14 tasks
danjm
pushed a commit
that referenced
this issue
Jan 31, 2025
…d modal (#30039) ## **Description** - This is a non-fork mirror of @darkwing's PR: #30005 Wraps the NFT list within the Send flow such that it will not overflow [](https://codespaces.new/MetaMask/metamask-extension/pull/30005?quickstart=1) ## **Related issues** Fixes: #29974 ## **Manual testing steps** 1. Use an account with many NFTs 2. Start send flow 3. Click the AssetPicker, choose NFTs 4. See the wrapped NFTs ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <img width="521" alt="SCR-20250130-hbwm" src="https://github.com/user-attachments/assets/abeb3b78-be50-4aa4-841f-f8441ba4103f" /> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> [](https://codespaces.new/MetaMask/metamask-extension/pull/30039?quickstart=1) ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. Co-authored-by: David Walsh <[email protected]>
](https://codespaces.new/MetaMask/metamask-extension/pull/30039?quickstart=1){kind=link}
1️⃣ What was the issue?The grid view was set to display as 4 columns and the images within them were set to a a fixed width, so when this NFT view was rendered in the AssetPicker, there was horizontal scrolling. 2️⃣ Why did it happen and why wasn’t it caught earlier?The engineer responsible wasn't aware that the grid view displayed in the AssetPicker. Since we don't have visual regression testing, automation didn't catch this. 3️⃣ What actions are we taking to prevent this in the future?With the knowledge that the NFTGrid is used in the AssetPicker, everyone is on the same page with reviews moving forward 4️⃣ Any related tickets and ETAs for follow-up actions?Talk to the Platform teams about implementing visual regression testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
In the NFT view within the Send flow, the token assets are displayed only partially, requiring users to scroll sideways to view all NFTs associated with their account.
Expected behavior
All NFT assets are fully visible or more easily navigable
Screenshots/Recordings
Screen.Recording.2025-01-29.at.11.18.58.mov
Steps to reproduce
Error messages or log output
Detection stage
During release testing
Version
12.11.0
Build type
None
Browser
Chrome, Firefox
Operating system
MacOS
Hardware wallet
No response
Additional context
No response
Severity
No response
The text was updated successfully, but these errors were encountered: