test: [POM] Migrate Send tx Revoke Permissions spec #29273

seaona · 2024-12-17T13:00:39Z

Description

Migrates test/e2e/tests/request-queuing/sendTx-revokePermissions.spec.js spec to POM and ts
Updates method classes to accommodate new functions needed in this spec
A new bug has been discovered thanks to this migration, and a new TODO has been added, to add a new spec to cover that flow, once the bug is fixed

Related issues

Fixes: #29276

Manual testing steps

Check ci
Run test yarn test:e2e:single test/e2e/tests/request-queuing/sendTx-revokePermissions.spec.ts --browser=chrome --leave-running=true

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-12-17T13:00:52Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

seaona · 2024-12-17T13:02:38Z

test/e2e/tests/request-queuing/sendTx-revokePermissions.spec.ts

+describe('Request Queuing', function () {
+  // TODO: add a new spec which checks that after revoking and connecting again
+  // a pending tx is still closed when using revokePermissions.
+  // To be done once this bug is fixed: #29272


a new bug has been discovered while migrating this spec.
Once the bug is fixed, we should add a new spec to verify that flow too.
Basically the first time we perform the flow it works as expected, but if we re-conenct to the dapp, trigger a new tx, and revoke permissions, that new tx is not cleared.

seaona · 2024-12-17T13:03:15Z

test/e2e/tests/request-queuing/sendTx-revokePermissions.spec.ts

+        await driver.switchToWindowWithTitle(WINDOW_TITLES.Dialog);
+
+        const transactionConfirmation = new TransactionConfirmation(driver);
+        await transactionConfirmation.check_dappInitiatedHeadingTitle();


we need to wait until the confirmation screen is loaded, otherwise we run into a race condition where the tx is not cleared, as it was not yet in the state

metamaskbot · 2024-12-17T13:34:06Z

Builds ready [e5e2467]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1771 ± 103 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	246	2348	1606	467	224
		domContentLoaded	1440	2212	1737	205	98
		load	1488	2349	1771	214	103
		domInteractive	23	106	48	24	12
		backgroundConnect	8	75	29	19	9
		firstReactRender	17	168	41	37	18
		getState	5	74	23	23	11
		initialActions	0	1	0	0	0
		loadScripts	1061	1688	1302	169	81
		setupStore	7	65	17	18	9
		uiStartup	1700	2809	2063	328	158

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2024-12-17T14:10:03Z

Builds ready [7ed25dd]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1917 ± 78 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	235	2195	1815	390	187
		domContentLoaded	1657	2248	1886	167	80
		load	1714	2255	1917	163	78
		domInteractive	28	179	56	36	17
		backgroundConnect	11	133	31	29	14
		firstReactRender	18	97	51	31	15
		getState	7	80	24	23	11
		initialActions	0	1	0	0	0
		loadScripts	1239	1703	1426	135	65
		setupStore	7	84	28	26	13
		uiStartup	1968	2953	2306	293	141

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

test/e2e/page-objects/pages/test-dapp.ts

chloeYue

LGTM !

metamaskbot · 2024-12-17T15:01:57Z

Builds ready [90dfcf1]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1601 ± 103 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	238	2109	1394	460	221
		domContentLoaded	1328	2211	1576	209	101
		load	1366	2235	1601	215	103
		domInteractive	21	78	33	16	8
		backgroundConnect	7	66	26	18	9
		firstReactRender	15	94	27	24	12
		getState	4	71	21	22	10
		initialActions	0	0	0	0	0
		loadScripts	978	1787	1187	185	89
		setupStore	6	9	7	1	0
		uiStartup	1551	2413	1882	226	109

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

migrate sendtx revoke to pom

e5e2467

metamaskbot added the team-extension-platform Extension Platform team label Dec 17, 2024

seaona commented Dec 17, 2024

View reviewed changes

seaona and others added 2 commits December 17, 2024 14:36

add test dapp account sconnected

2998abe

Merge branch 'main' into pom-sendtx-revokepermissions

7ed25dd

seaona self-assigned this Dec 17, 2024

seaona added e2e-test End to end test for the MetaMask extension area-qa Relating to QA work (Quality Assurance) labels Dec 17, 2024

chloeYue reviewed Dec 17, 2024

View reviewed changes

test/e2e/page-objects/pages/test-dapp.ts Outdated Show resolved Hide resolved

use connectedAccount var

90dfcf1

cmd-ob approved these changes Dec 17, 2024

View reviewed changes

chloeYue approved these changes Dec 17, 2024

View reviewed changes

chloeYue added this pull request to the merge queue Dec 17, 2024

Merged via the queue into main with commit a31d808 Dec 17, 2024
77 checks passed

chloeYue deleted the pom-sendtx-revokepermissions branch December 17, 2024 15:55

github-actions bot locked and limited conversation to collaborators Dec 17, 2024

metamaskbot added the release-12.11.0 Issue or pull request that will be included in release 12.11.0 label Dec 17, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

test: [POM] Migrate Send tx Revoke Permissions spec #29273

test: [POM] Migrate Send tx Revoke Permissions spec #29273

Uh oh!

seaona commented Dec 17, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Dec 17, 2024

Uh oh!

seaona Dec 17, 2024

Uh oh!

seaona Dec 17, 2024

Uh oh!

metamaskbot commented Dec 17, 2024

Uh oh!

metamaskbot commented Dec 17, 2024

Uh oh!

Uh oh!

chloeYue left a comment

Uh oh!

metamaskbot commented Dec 17, 2024

Uh oh!

Uh oh!

Uh oh!

test: [POM] Migrate Send tx Revoke Permissions spec #29273

test: [POM] Migrate Send tx Revoke Permissions spec #29273

Uh oh!

Conversation

seaona commented Dec 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Dec 17, 2024

Uh oh!

seaona Dec 17, 2024

Choose a reason for hiding this comment

Uh oh!

seaona Dec 17, 2024

Choose a reason for hiding this comment

Uh oh!

metamaskbot commented Dec 17, 2024

Uh oh!

metamaskbot commented Dec 17, 2024

Uh oh!

Uh oh!

chloeYue left a comment

Choose a reason for hiding this comment

Uh oh!

metamaskbot commented Dec 17, 2024

Uh oh!

Uh oh!

Uh oh!

seaona commented Dec 17, 2024 •

edited

Loading