Skip to content

[Bug]: Permissions - Using wallet_revokePermissions a second time does not clear pending tx's #29272

Closed
@seaona

Description

@seaona

Describe the bug

Whenever I have a pending transaction and I use the wallet_revokePermissions method, that transaction is then cleared, as expected.
However, if I connect again into the dapp and trigger a new transaction and then again the wallet_revokePermissions, that transaction is not cleared.

Expected behavior

We should clear pending transactions anytime wallet_revokePermissions is used.
The PR which fixes the issue should also add an e2e for it here, as the current test doesn't cover this more complex scenario.

Screenshots/Recordings

revoke-permission-not-clear-txs.mp4

Steps to reproduce

  1. With a fresh install, go to the test dapp
  2. Connect
  3. Trigger a transaction (don't accept or reject)
  4. Open dapp console
  5. Trigger the request wallet_revokePermissions
  6. See tx is cleared
  7. Connect again to the test dapp
  8. Trigger a transaction (don't accept or reject)
  9. Trigger the request wallet_revokePermissions
  10. See tx is not cleared
await window.ethereum.request({
  method: 'wallet_revokePermissions',
  params: [
    {
      eth_accounts: {},
    },
  ],
})

Error messages or log output

Detection stage

In production (default)

Version

12.9.1

Build type

None

Browser

Chrome

Operating system

Linux

Hardware wallet

No response

Additional context

No response

Severity

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    Sev2-normalNormal severity; minor loss of service or inconvenience.regression-prod-12.9.1Regression bug that was found in production in release 12.9.1team-confirmationsPush issues to confirmations teamtype-bugSomething isn't working

    Type

    No type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions