Skip to content

fix: Permit signature re-design papercuts #25383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 21, 2024
Merged

fix: Permit signature re-design papercuts #25383

merged 7 commits into from
Jun 21, 2024

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Jun 18, 2024

Description

Open in GitHub Codespaces

Related issues

Fixes: #25325

Manual testing steps

  1. Go to test dapp
  2. Submit permit signature request
  3. Check designs of confirmation page

Screenshots/Recordings

Screenshot 2024-06-18 at 5 48 30 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added confirmation-redesign team-confirmations Push issues to confirmations team labels Jun 18, 2024
@jpuri jpuri requested a review from a team as a code owner June 18, 2024 12:15
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

matthewwalsh0
matthewwalsh0 previously approved these changes Jun 18, 2024
vinistevam
vinistevam previously approved these changes Jun 19, 2024
Copy link

codecov bot commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.39%. Comparing base (2115516) to head (4f51e69).
Report is 25 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #25383      +/-   ##
===========================================
- Coverage    65.39%   65.39%   -0.00%     
===========================================
  Files         1382     1382              
  Lines        54764    54762       -2     
  Branches     14369    14368       -1     
===========================================
- Hits         35809    35807       -2     
  Misses       18955    18955              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [81f3ecd]
Page Load Metrics (61 ± 6 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint6811696147
domContentLoaded9331463
load449361136
domInteractive9331463
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 22 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [78a9317]
Page Load Metrics (48 ± 4 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint65937963
domContentLoaded8241142
load40744884
domInteractive8241142
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 22 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@jpuri jpuri requested a review from OGPoyraz June 20, 2024 13:27
@jpuri jpuri merged commit 5c8e1a9 into develop Jun 21, 2024
73 of 74 checks passed
@jpuri jpuri deleted the permit_papercuts branch June 21, 2024 11:55
@github-actions github-actions bot locked and limited conversation to collaborators Jun 21, 2024
@metamaskbot metamaskbot added the release-12.1.0 Issue or pull request that will be included in release 12.1.0 label Jun 21, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [4f51e69]
Page Load Metrics (124 ± 168 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint6513981168
domContentLoaded811910
load391653124351168
domInteractive811910
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 1 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
confirmation-redesign release-12.1.0 Issue or pull request that will be included in release 12.1.0 team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Signatures Redesign] Design papercuts
6 participants