-
Notifications
You must be signed in to change notification settings - Fork 5.2k
fix: Permit signature re-design papercuts #25383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
matthewwalsh0
previously approved these changes
Jun 18, 2024
digiwand
reviewed
Jun 19, 2024
ui/pages/confirmations/components/confirm/info/__snapshots__/info.test.tsx.snap
Outdated
Show resolved
Hide resolved
vinistevam
previously approved these changes
Jun 19, 2024
OGPoyraz
reviewed
Jun 19, 2024
...ges/confirmations/components/confirm/info/typed-sign/permit-simulation/permit-simulation.tsx
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #25383 +/- ##
===========================================
- Coverage 65.39% 65.39% -0.00%
===========================================
Files 1382 1382
Lines 54764 54762 -2
Branches 14369 14368 -1
===========================================
- Hits 35809 35807 -2
Misses 18955 18955 ☔ View full report in Codecov by Sentry. |
Builds ready [81f3ecd]
Page Load Metrics (61 ± 6 ms)
Bundle size diffs
|
Builds ready [78a9317]
Page Load Metrics (48 ± 4 ms)
Bundle size diffs
|
matthewwalsh0
approved these changes
Jun 20, 2024
OGPoyraz
approved these changes
Jun 21, 2024
Builds ready [4f51e69]
Page Load Metrics (124 ± 168 ms)
Bundle size diffs
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
confirmation-redesign
release-12.1.0
Issue or pull request that will be included in release 12.1.0
team-confirmations
Push issues to confirmations team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issues
Fixes: #25325
Manual testing steps
Screenshots/Recordings
Pre-merge author checklist
Pre-merge reviewer checklist