Skip to content

[Signatures Redesign] Design papercuts #25325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
9 tasks
bschorchit opened this issue Jun 14, 2024 · 0 comments · Fixed by #25383
Closed
9 tasks

[Signatures Redesign] Design papercuts #25325

bschorchit opened this issue Jun 14, 2024 · 0 comments · Fixed by #25383
Assignees
@jpuri
Labels
regression-RC-12.0.0 release-12.1.0 Issue or pull request that will be included in release 12.1.0 team-confirmations Push issues to confirmations team

Comments

@bschorchit
Copy link

bschorchit commented Jun 14, 2024 •
edited
Loading

What is this about?

We should address the following design papercuts:
Screenshot 2024-06-18 at 10 40 27

Scenario

  1. Go to test dapp
  2. Click on Malicious Permit

Design

Figma

Technical Details

No response

Threat Modeling Framework

No response

Acceptance Criteria

No response

Stakeholder review needed before the work gets merged

  • Engineering (needed in most cases)
  • Design
  • Product
  • QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
  • Security
  • Legal
  • Marketing
  • Management (please specify)
  • Other (please specify)

References

No response
@bschorchit bschorchit added the team-confirmations Push issues to confirmations team label Jun 14, 2024
@jpuri jpuri self-assigned this Jun 14, 2024
@jpuri jpuri mentioned this issue Jun 18, 2024
Merged
7 tasks
@metamaskbot metamaskbot added the release-12.1.0 Issue or pull request that will be included in release 12.1.0 label Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jpuri jpuri

Labels
regression-RC-12.0.0 release-12.1.0 Issue or pull request that will be included in release 12.1.0 team-confirmations Push issues to confirmations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Permit signature re-design papercuts MetaMask/metamask-extension
3 participants
@jpuri @bschorchit @metamaskbot