feat(2404): change mv3 as main build besides firefox #24746

DDDDDanica · 2024-05-23T14:57:31Z

Description

Make MV3 build as default one besides firefox related pipelines

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/2404

Manual testing steps

Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

I’ve followed MetaMask Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-05-23T14:57:45Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

DDDDDanica · 2024-05-23T23:51:24Z

@metamaskbot update-policies

metamaskbot · 2024-05-24T00:00:48Z

Policies updated

DDDDDanica · 2024-05-24T11:06:04Z

@metamaskbot update-policies

DDDDDanica · 2024-05-24T11:07:16Z

@metamaskbot update-policies

metamaskbot · 2024-05-24T11:14:05Z

Policies updated

metamaskbot · 2024-05-24T11:15:09Z

No policy changes

DDDDDanica · 2024-05-27T07:39:11Z

@metamaskbot update-policies

metamaskbot · 2024-05-27T07:47:31Z

No policy changes

metamaskbot · 2024-05-30T13:35:49Z

Builds ready [0916395]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (47 ± 3 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	69	99	81	8	4
		domContentLoaded	8	24	10	3	2
		load	42	68	47	6	3
		domInteractive	8	24	10	3	2

danjm

LGTM

metamaskbot · 2024-05-30T14:38:45Z

Builds ready [0916395]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (47 ± 3 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	69	99	81	8	4
		domContentLoaded	8	24	10	3	2
		load	42	68	47	6	3
		domInteractive	8	24	10	3	2

davidmurdoch · 2024-05-30T17:14:13Z

development/build/manifest.js

+      shouldIncludeMV3:
+        process.env.ENABLE_MV3 === 'true' ||
+        process.env.ENABLE_MV3 === undefined,


nit:

Suggested change

shouldIncludeMV3:

process.env.ENABLE_MV3 === 'true' ||

process.env.ENABLE_MV3 === undefined,

shouldIncludeMV3: IS_MV3_ENABLED,

davidmurdoch · 2024-05-30T17:28:54Z

builds.yml

@@ -192,7 +192,7 @@ env:
  - SKIP_BACKGROUND_INITIALIZATION: false

  # TODO(ritave): Move ManifestV3 into a feature?


safe to remove the todo here? I doubt we'll ever move it to a "feature".

Good catch ! removed

development/build/manifest.js

metamaskbot · 2024-05-30T20:57:23Z

Builds ready [2197e3f]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (347 ± 294 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	70	154	88	17	8
		domContentLoaded	8	22	11	3	2
		load	42	2073	347	612	294
		domInteractive	8	22	11	3	2

metamaskbot · 2024-05-30T20:59:47Z

Builds ready [2197e3f]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (347 ± 294 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	70	154	88	17	8
		domContentLoaded	8	22	11	3	2
		load	42	2073	347	612	294
		domInteractive	8	22	11	3	2

metamaskbot · 2024-05-31T00:28:35Z

Builds ready [60071ab]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (109 ± 129 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	70	91	81	6	3
		domContentLoaded	9	16	10	2	1
		load	42	1278	109	268	129
		domInteractive	9	16	10	2	1

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

danjm · 2024-05-31T00:43:43Z

I tested the chrome and firefox main and flask builds. And MMI chrome builds (MMI only publishes to chrome). Looks good!

davidmurdoch

Looks pretty good! Though I think there will be some follow up work for bits we may have missed, as there are a lot of subtle changes in here.

metamaskbot · 2024-06-04T20:07:49Z

Missing release label release-11.16.6 on PR. Adding release label release-11.16.6 on PR and removing other release labels(release-11.18.0), as PR was cherry-picked in branch 11.16.6.

DDDDDanica added the team-extension-platform Extension Platform team label May 23, 2024

DDDDDanica self-assigned this May 23, 2024

DDDDDanica requested review from kumavis and a team as code owners May 23, 2024 14:57

DDDDDanica force-pushed the feature/2404 branch 10 times, most recently from cb8da54 to 4adbfc4 Compare May 23, 2024 23:50

metamaskbot requested review from a team as code owners May 24, 2024 00:00

DDDDDanica force-pushed the feature/2404 branch from cc3c2d3 to c0845d5 Compare May 24, 2024 10:47

DDDDDanica force-pushed the feature/2404 branch from c0845d5 to 25916f3 Compare May 24, 2024 11:07

DDDDDanica force-pushed the feature/2404 branch from bc6ff81 to 8446983 Compare May 27, 2024 07:38

DDDDDanica force-pushed the feature/2404 branch from 8446983 to 703915b Compare May 29, 2024 09:57

DDDDDanica force-pushed the feature/2404 branch 2 times, most recently from ee4fb09 to 94c2d25 Compare May 30, 2024 11:27

DDDDDanica added 2 commits May 30, 2024 13:29

feat(2404): change mv3 as main build besides firefox

5ecdb92

feature(2404): add firefox support in build ymal file

0916395

DDDDDanica force-pushed the feature/2404 branch from 94c2d25 to 0916395 Compare May 30, 2024 12:29

DDDDDanica changed the title ~~WIP: feat(2404): change mv3 as main build besides firefox~~ feat(2404): change mv3 as main build besides firefox May 30, 2024

danjm previously approved these changes May 30, 2024

View reviewed changes

davidmurdoch requested changes May 30, 2024

View reviewed changes

danjm dismissed their stale review via d0f3a99 May 30, 2024 18:35

Ensure firefox prod builds are mv2

654d3fc

danjm force-pushed the feature/2404 branch from d0f3a99 to 654d3fc Compare May 30, 2024 18:36

fix: fix build announcement and address some comments

2197e3f

danjm previously approved these changes May 30, 2024

View reviewed changes

Fix publishing of bundle size diffs by the metamask bot

60071ab

danjm dismissed their stale review via 60071ab May 30, 2024 23:31

danjm approved these changes May 31, 2024

View reviewed changes

davidmurdoch approved these changes May 31, 2024

View reviewed changes

danjm merged commit 6168b3a into develop May 31, 2024
77 checks passed

danjm deleted the feature/2404 branch May 31, 2024 02:03

github-actions bot locked and limited conversation to collaborators May 31, 2024

metamaskbot added release-11.18.0 release-11.16.6 Issue or pull request that will be included in release 11.16.6 and removed release-11.18.0 labels May 31, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(2404): change mv3 as main build besides firefox #24746

feat(2404): change mv3 as main build besides firefox #24746

DDDDDanica commented May 23, 2024 •

edited

Loading

github-actions bot commented May 23, 2024

DDDDDanica commented May 23, 2024

metamaskbot commented May 24, 2024

DDDDDanica commented May 24, 2024

DDDDDanica commented May 24, 2024

metamaskbot commented May 24, 2024

metamaskbot commented May 24, 2024

DDDDDanica commented May 27, 2024

metamaskbot commented May 27, 2024

metamaskbot commented May 30, 2024

danjm left a comment

metamaskbot commented May 30, 2024

davidmurdoch May 30, 2024

davidmurdoch May 30, 2024

DDDDDanica May 30, 2024

metamaskbot commented May 30, 2024

metamaskbot commented May 30, 2024

metamaskbot commented May 31, 2024

danjm commented May 31, 2024

davidmurdoch left a comment

metamaskbot commented Jun 4, 2024

		@@ -192,7 +192,7 @@ env:
		- SKIP_BACKGROUND_INITIALIZATION: false

		# TODO(ritave): Move ManifestV3 into a feature?

feat(2404): change mv3 as main build besides firefox #24746

feat(2404): change mv3 as main build besides firefox #24746

Conversation

DDDDDanica commented May 23, 2024 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented May 23, 2024

DDDDDanica commented May 23, 2024

metamaskbot commented May 24, 2024

DDDDDanica commented May 24, 2024

DDDDDanica commented May 24, 2024

metamaskbot commented May 24, 2024

metamaskbot commented May 24, 2024

DDDDDanica commented May 27, 2024

metamaskbot commented May 27, 2024

metamaskbot commented May 30, 2024

danjm left a comment

Choose a reason for hiding this comment

metamaskbot commented May 30, 2024

davidmurdoch May 30, 2024

Choose a reason for hiding this comment

davidmurdoch May 30, 2024

Choose a reason for hiding this comment

DDDDDanica May 30, 2024

Choose a reason for hiding this comment

metamaskbot commented May 30, 2024

metamaskbot commented May 30, 2024

metamaskbot commented May 31, 2024

danjm commented May 31, 2024

davidmurdoch left a comment

Choose a reason for hiding this comment

metamaskbot commented Jun 4, 2024

DDDDDanica commented May 23, 2024 •

edited

Loading