fix: fix build announcement and address some comments

Author: DDDDDanica

builds.yml

@@ -191,7 +191,6 @@ env:
   - SUPPORT_REQUEST_LINK: https://metamask.zendesk.com/hc/en-us
   - SKIP_BACKGROUND_INITIALIZATION: false
 
-  # TODO(ritave): Move ManifestV3 into a feature?
   - ENABLE_MV3: true
   # These are exclusively used for MV3
   - USE_SNOW

development/build/manifest.js

@@ -139,9 +139,7 @@ function createManifestTasks({
       buildType,
       applyLavaMoat,
       shouldIncludeSnow,
-      shouldIncludeMV3:
-        process.env.ENABLE_MV3 === 'true' ||
-        process.env.ENABLE_MV3 === undefined,
+      shouldIncludeMV3: IS_MV3_ENABLED,
     });
 
     manifest.description = `${environment} build from git id: ${gitRevisionStr}`;

development/metamaskbot-build-announce.js

@@ -68,18 +68,20 @@ async function start() {
   const platforms = ['chrome', 'firefox'];
   const buildLinks = platforms
     .map((platform) => {
-      const url = platform === 'firefox'
-        ? `${BUILD_LINK_BASE}/builds-mv2/metamask-${platform}-${VERSION}.zip`;
-        : `${BUILD_LINK_BASE}/builds/metamask-${platform}-${VERSION}.zip`;
+      const url =
+        platform === 'firefox'
+          ? `${BUILD_LINK_BASE}/builds-mv2/metamask-${platform}-${VERSION}.zip`
+          : `${BUILD_LINK_BASE}/builds/metamask-${platform}-${VERSION}.zip`;
       return `<a href="${url}">${platform}</a>`;
     })
     .join(', ');
   const betaBuildLinks = `<a href="${BUILD_LINK_BASE}/builds-beta/metamask-beta-chrome-${VERSION}.zip">chrome</a>`;
   const flaskBuildLinks = platforms
     .map((platform) => {
-      const url = platform === 'firefox'
-        ? `${BUILD_LINK_BASE}/builds-flask-mv2/metamask-flask-${platform}-${VERSION}-flask.0.zip`;
-        : `${BUILD_LINK_BASE}/builds-flask/metamask-flask-${platform}-${VERSION}-flask.0.zip`;
+      const url =
+        platform === 'firefox'
+          ? `${BUILD_LINK_BASE}/builds-flask-mv2/metamask-flask-${platform}-${VERSION}-flask.0.zip`
+          : `${BUILD_LINK_BASE}/builds-flask/metamask-flask-${platform}-${VERSION}-flask.0.zip`;
       return `<a href="${url}">${platform}</a>`;
     })
     .join(', ');
@@ -91,17 +93,19 @@ async function start() {
     .join(', ');
   const testBuildLinks = platforms
     .map((platform) => {
-      const url = platform === 'firefox'
-        ? ${BUILD_LINK_BASE}/builds-test-mv2/metamask-${platform}-${VERSION}.zip`;
-        : ${BUILD_LINK_BASE}/builds-test/metamask-${platform}-${VERSION}.zip`;
+      const url =
+        platform === 'firefox'
+          ? `${BUILD_LINK_BASE}/builds-test-mv2/metamask-${platform}-${VERSION}.zip`
+          : `${BUILD_LINK_BASE}/builds-test/metamask-${platform}-${VERSION}.zip`;
       return `<a href="${url}">${platform}</a>`;
     })
     .join(', ');
   const testFlaskBuildLinks = platforms
     .map((platform) => {
-      const url = platform === 'firefox'
-        ? `${BUILD_LINK_BASE}/builds-test-flask-mv2/metamask-flask-${platform}-${VERSION}-flask.0.zip`;
-        ? `${BUILD_LINK_BASE}/builds-test-flask/metamask-flask-${platform}-${VERSION}-flask.0.zip`;
+      const url =
+        platform === 'firefox'
+          ? `${BUILD_LINK_BASE}/builds-test-flask-mv2/metamask-flask-${platform}-${VERSION}-flask.0.zip`
+          : `${BUILD_LINK_BASE}/builds-test-flask/metamask-flask-${platform}-${VERSION}-flask.0.zip`;
       return `<a href="${url}">${platform}</a>`;
     })
     .join(', ');