Skip to content

[Bug]: Keyboard shortcut (Alt+Shift+M) broken on Chrome #31837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Gudahtt opened this issue Apr 10, 2025 · 2 comments · Fixed by #31844 · May be fixed by #31956
Closed

[Bug]: Keyboard shortcut (Alt+Shift+M) broken on Chrome #31837

Gudahtt opened this issue Apr 10, 2025 · 2 comments · Fixed by #31844 · May be fixed by #31956
Labels
regression-prod-11.16.7 Regression bug that was found in production in release 11.16.7 Sev2-normal Normal severity; minor loss of service or inconvenience. team-extension-platform Extension Platform team type-bug Something isn't working

Comments

@Gudahtt
Copy link
Member

Gudahtt commented Apr 10, 2025

Describe the bug

The keyboard shortcut for opening MetaMask is broken on Chrome, ever since the migration to MV3.

Expected behavior

Alt+Shift+M should open the browser-action popup.

Screenshots/Recordings

No response

Steps to reproduce

Install the extension in Chrome, and type Alt+Shift+M

Error messages or log output



Detection stage


In production (default)


Version


11.16.7


Build type


None


Browser


Chrome


Operating system


MacOS


Hardware wallet


No response


Additional context


No response


Severity


No response

      		
    

      
  





        



            
            

              
            

        

      


      
    








      

    



      

  
            

    

      
    

    


      

          @Gudahtt
Gudahtt




          added
  the 

  type-bug

  Something isn't working
 label


      Apr 10, 2025

    

  



    

    

      
    

    


      

          @github-project-automation
github-project-automation
bot



          moved this to To be fixed
  in Bugs by severity


      Apr 10, 2025

    

  



    


    

    

      
    

    


      

          @github-project-automation
github-project-automation
bot



          moved this to To be triaged
  in Bugs by team


      Apr 10, 2025

    

  



    

    

      
    

    


      

          @Gudahtt
Gudahtt




            added
      

  team-extension-platform

  Extension Platform team

      

  Sev2-normal

  Normal severity; minor loss of service or inconvenience.

  labels


      Apr 10, 2025

    

  



  

  

    
  


  

      

    @Gudahtt
Gudahtt



    mentioned this issue
    
      Apr 10, 2025
    





  


  

      
   Merged

  





  
  

      
        
      
      

  
    
    
  


    7 tasks
  





  




    

    

      
    

    


      

          @metamaskbot
metamaskbot




            added
      

  regression-prod-11.16.7

  Regression bug that was found in production in release 11.16.7

      

  needs-triage

  Issue needs to be triaged

  labels


      Apr 10, 2025

    

  



    

    

      
    

    


      

          @Gudahtt
Gudahtt




          removed
  the 

  needs-triage

  Issue needs to be triaged
 label


      Apr 10, 2025

    

  








      

  
      



  

  @Teng-Web3





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
    Contributor


      

  


  

    

  





      


        


  
    

      
          
Please assign this to me

      		
    

  





        


            

            
            

              
            

        

      


      

            
  

    
  
    
    

  

  


    












      

  
          

  

    
  


  

      

    @Teng-Web3
Teng-Web3



    mentioned this issue
    
      Apr 10, 2025
    





  


  

      
   Merged

  





  
  

      
        
      
      

  
    
    
  


    7 tasks
  





  




  


  
    
  
  

    
  github-merge-queue bot

      pushed a commit
      that referenced
      this issue

    
      Apr 14, 2025
    
    

      


  

    

      


  

      
        @Teng-Web3
  





      

        
          fix: keyboard shortcut(Alt+Shift+M) broken on Chrome (#31844)
        

          
            
          

      


      

          

    
    
    

  

    


      


      

          

    
    
    

  

  

    
  



      


      
      

        
          c690de7
        
      

    

  

    

      
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

</tbody><!--EndFragment-->
</body>
</html>
"_execute_browser_action" is no longer available in Chrome MV3, should
use "_execute_action". but "_execute_action" doesn't work in
Firefox(Firefox MV3 only support "_execute_browser_action" now).

**Solution**:
Add both "_execute_browser_action" and "_execute_action" in config file

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/31844?quickstart=1)

## **Related issues**

Fixes: #31837

## **Manual testing steps**

1. Install the extension in Chrome
2. Open Chrome and type Alt+Shift+M
3. Check if popup opend

## **Screenshots/Recordings**
### **After**
Test in Chrome:


https://github.com/user-attachments/assets/7bfc858f-7da1-4931-b100-c44e28dfee93

Test in Firefox:


https://github.com/user-attachments/assets/32d6e330-c226-49b6-ae40-41ece5e509dd


<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

    




    

  




    

    


    

    

      
    

    


      

          @github-project-automation
github-project-automation
bot



          moved this from To be fixed
  to Fixed
  in Bugs by severity


      Apr 14, 2025

    

  








      

  
      



  

  @Teng-Web3





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
    Contributor


      

  


  

    

      

      
            Teng-Web3
  

      

      

      commented


        Apr 15, 2025


      
  •

  

    
      

        
          edited
          
        
        
      

    
    
      
        
      Loading

    
  



    


  





      


        


  
    

      
          
Hi @HowardBraham , thank you for your suggestions.

About your comments(I will reply you here because the conversation has been locked and limited to collaborators here #31844):


    

  1. I will create a new PR to add a "default" to align with chore: cp-12.16.0 Add default platform for suggested key #31812, @seaona and @chloeYue please help to review.
    2. 

  2. I test passed on Brave with version 1.77.97 Chromium: 135.0.7049.84:
    3. 




  
    
    brave.mp4
    
  

  



      		
    

  





        


            

            
            

              
            

        

      


      

            
  

    
  
    
    

  

  


    












      

  
          

  

    
  


  

      

    @Teng-Web3
Teng-Web3



    mentioned this issue
    
      Apr 15, 2025
    





  


  

      
   Open

  





  
  

      
        
      
      

  
    
    
  


    7 tasks
  





  




    











  
  

    

      

  





  




  
  

              

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  



  






  
                  




    

  


      
  

    Assignees
  



        

    No one assigned







      


  


  

    Labels
  



    

      

    regression-prod-11.16.7

  Regression bug that was found in production in release 11.16.7
  

    Sev2-normal

  Normal severity; minor loss of service or inconvenience.
  

    team-extension-platform

  Extension Platform team
  

    type-bug

  Something isn't working








      

  

    

        

    Projects
  


        




        
  

    

      
          
        Bugs by severity
        
    

    

      

          

  

    
      Archived in project



      

    

    

  







  



      


  

    
  

    Milestone
  


      No milestone





    
      
          


  

    
  




      

    

  
      

  

    

      3 participants
    

    

        
          @Gudahtt 
        
          @metamaskbot 
        
          @Teng-Web3