Skip to content

Commit c690de7

Browse files
authored
fix: keyboard shortcut(Alt+Shift+M) broken on Chrome (#31844)
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** </tbody><!--EndFragment--> </body> </html> "_execute_browser_action" is no longer available in Chrome MV3, should use "_execute_action". but "_execute_action" doesn't work in Firefox(Firefox MV3 only support "_execute_browser_action" now). **Solution**: Add both "_execute_browser_action" and "_execute_action" in config file <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/31844?quickstart=1) ## **Related issues** Fixes: #31837 ## **Manual testing steps** 1. Install the extension in Chrome 2. Open Chrome and type Alt+Shift+M 3. Check if popup opend ## **Screenshots/Recordings** ### **After** Test in Chrome: https://github.com/user-attachments/assets/7bfc858f-7da1-4931-b100-c44e28dfee93 Test in Firefox: https://github.com/user-attachments/assets/32d6e330-c226-49b6-ae40-41ece5e509dd <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
1 parent 4691f2f commit c690de7

File tree

1 file changed

+8
-0
lines changed

1 file changed

+8
-0
lines changed

app/manifest/v3/_base.json

+8
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,14 @@
1818
},
1919
"commands": {
2020
"_execute_browser_action": {
21+
"suggested_key": {
22+
"windows": "Alt+Shift+M",
23+
"mac": "Alt+Shift+M",
24+
"chromeos": "Alt+Shift+M",
25+
"linux": "Alt+Shift+M"
26+
}
27+
},
28+
"_execute_action": {
2129
"suggested_key": {
2230
"default": "Alt+Shift+M",
2331
"windows": "Alt+Shift+M",

0 commit comments

Comments
 (0)