Translatable Strings for ubl_G29 #6990
Conversation
| #endif | ||
| #ifndef MSG_UBL_RESTORE_ERROR | ||
| #define MSG_UBL_RESTORE_ERROR _UxGT("restore_UBL_active() error") | ||
| #endif |
There was a problem hiding this comment.
Question: Shouldn't we stay below 20 characters? Only asking, because translating to german would be much easier having more space.
There was a problem hiding this comment.
Absolutely. Below 18 is even better. Below 16 ftw. Strings may also be adapted to screen width. I understand we all like to make things work with our hardware but let's think of others too.
Anyway errors like "restore_UBL_active() error" are obviously awful and obviously need replacement before merging this PR.
There was a problem hiding this comment.
I tried to help on some of the TODO's.
LCD_MESSAGEPGM("restore_UBL_active() error"); // TODO: Make translatable string
Since this was still there, I took it as being accepted.
Changing the error message is fine... I agree.
There was a problem hiding this comment.
Would this be better?
#ifndef MSG_UBL_SAVE_ERROR
#define MSG_UBL_SAVE_ERROR _UxGT("save error")
#endif
#ifndef MSG_UBL_RESTORE_ERROR
#define MSG_UBL_RESTORE_ERROR _UxGT("restore error")
#endif
There was a problem hiding this comment.
I have a commit in a PR with "Err: UBL Save" and "Err: UBL Restore". These are internal errors that should only occur if there are bugs in the code.
There was a problem hiding this comment.
I already took "Err: UBL Save" and "Err: UBL Restore" into the german translation PR. So i'm fine with them
Following MarlinFirmware#6990 some more translations and some grammar fixes
Following MarlinFirmware#6990 some more translations and some grammar fixes
Following MarlinFirmware#6990 some more translations and some grammar fixes
Following MarlinFirmware#6990 some more translations and some grammar fixes
No description provided.