Skip to content

LCD : MKS_H43 refactoring follow-up #27780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 7, 2025

Conversation

narno2202
Copy link
Contributor

Description

Update overloaded sendInfoScreen for MKS_H43 in DGUSScreenHandler.cpp and update code accordingly

Requirements

MKS H43 display

Benefits

Configurations

Related Issues

@thinkyhead
Copy link
Member

For future-readiness with AVR or other Arduino targets that use a "PROGMEM" accessor we should have both the "_P" form of the method and the regular (C-string) form. The one that takes FSTR_P should call through to the "_P" version of the method. The use of C-string will actually be the exception and will only apply to strings that are composed (usually because they can be changed at runtime).

@narno2202
Copy link
Contributor Author

Ah, all right, I did it because the function is never called. Now it's more clear for me.

@thinkyhead thinkyhead merged commit d7b7354 into MarlinFirmware:bugfix-2.1.x Apr 7, 2025
65 checks passed
EvilGremlin pushed a commit to EvilGremlin/Marlin that referenced this pull request May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants