-
-
Notifications
You must be signed in to change notification settings - Fork 19.5k
LCD: refactor MKS H43 display code and UI #27776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Looking pretty good, but there were a variety of actual bugs. I'll merge all the cosmetic changes separately so the more relevant changes will be more obvious here … for posterity. |
36542b7
to
1bd6a75
Compare
Strings in Arduino can sometimes be tricky to understand and we haven't propagated consistent string usage to all parts of the code yet, sorry about that.
Speaking of |
As with the |
Co-authored-by: Scott Lahteine <[email protected]>
Description
For my personal use, I have refactored the MKS H43 code and I am submitting this PR.
Summary of changes :
Requirements
MKS H43 display
Benefits
More consistency in the UI, bug fix
Configurations
Related Issues