Fixing scoring for unlimited point to ensure there 1 or more points for it to be considered scorable. #2018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… or more points for it to be considered scorable.
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (6dcb14d) and published it to npm. You Example: yarn add @khanacademy/perseus@PR2018If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR2018 |
|
Size Change: +47 B (0%) Total Size: 1.27 MB
ℹ️ View Unchanged
|
nishasy
approved these changes
Dec 17, 2024
anakaren-rojas
approved these changes
Dec 17, 2024
Merged
somewhatabstract
added a commit
that referenced
this pull request
Dec 18, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @khanacademy/[email protected] ### Patch Changes - [#2022](#2022) [`266d240ed`](266d240) Thanks [@somewhatabstract](https://github.com/somewhatabstract)! - Update to Wonder Blocks without custom ID generation API ## @khanacademy/[email protected] ### Patch Changes - [#2017](#2017) [`4508e7bea`](4508e7b) Thanks [@nishasy](https://github.com/nishasy)! - [SR] Minor improvements to Circle graph SR strings - [#2022](#2022) [`266d240ed`](266d240) Thanks [@somewhatabstract](https://github.com/somewhatabstract)! - Update to Wonder Blocks without custom ID generation API - [#2018](#2018) [`1fe437079`](1fe4370) Thanks [@catandthemachines](https://github.com/catandthemachines)! - Fixing scoring for unlimited point to ensure there 1 or more points for it to be considered scorable. - Updated dependencies \[[`266d240ed`](266d240)]: - @khanacademy/[email protected] ## @khanacademy/[email protected] ### Patch Changes - [#2022](#2022) [`266d240ed`](266d240) Thanks [@somewhatabstract](https://github.com/somewhatabstract)! - Update to Wonder Blocks without custom ID generation API - Updated dependencies \[[`4508e7bea`](4508e7b), [`266d240ed`](266d240), [`1fe437079`](1fe4370)]: - @khanacademy/[email protected] - @khanacademy/[email protected] ## @khanacademy/[email protected] ### Patch Changes - [#2022](#2022) [`266d240ed`](266d240) Thanks [@somewhatabstract](https://github.com/somewhatabstract)! - Update to Wonder Blocks without custom ID generation API - Updated dependencies \[[`266d240ed`](266d240)]: - @khanacademy/[email protected]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Refining scoring behavior for unlimited point to ensure it treats an empty graph as unscorable.
Issue: LEMS-2682
Test plan:
Go to http://localhost:6006/?path=/story/perseus-widgets-interactive-graph--point-with-mafs
Add a bunch of points and remove them until there is none left.
Check your answer and notice the score is defined as
invalid.