[SR] Minor improvements to Circle graph SR strings #2017
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update the variable names to start with `sr` prefix. - Use `srFormatNumber()` to make sure the numbers are formatted correctly. - Update the coordinate types to `string` in the strings instead of `number` since they are now using `srFormatNumber()` (which returns a string) Issue: https://khanacademy.atlassian.net/browse/LEMS-1706 Test plan: `yarn jest` - Go to http://localhost:6006/iframe.html?globals=&args=&id=perseuseditor-widgets-interactive-graph--interactive-graph-circle&viewMode=story - Confirm nothing has changed from before
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (fe89bc4) and published it to npm. You Example: yarn add @khanacademy/perseus@PR2017If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR2017 |
|
Size Change: +6 B (0%) Total Size: 1.27 MB
ℹ️ View Unchanged
|
Merged
somewhatabstract
added a commit
that referenced
this pull request
Dec 18, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @khanacademy/[email protected] ### Patch Changes - [#2022](#2022) [`266d240ed`](266d240) Thanks [@somewhatabstract](https://github.com/somewhatabstract)! - Update to Wonder Blocks without custom ID generation API ## @khanacademy/[email protected] ### Patch Changes - [#2017](#2017) [`4508e7bea`](4508e7b) Thanks [@nishasy](https://github.com/nishasy)! - [SR] Minor improvements to Circle graph SR strings - [#2022](#2022) [`266d240ed`](266d240) Thanks [@somewhatabstract](https://github.com/somewhatabstract)! - Update to Wonder Blocks without custom ID generation API - [#2018](#2018) [`1fe437079`](1fe4370) Thanks [@catandthemachines](https://github.com/catandthemachines)! - Fixing scoring for unlimited point to ensure there 1 or more points for it to be considered scorable. - Updated dependencies \[[`266d240ed`](266d240)]: - @khanacademy/[email protected] ## @khanacademy/[email protected] ### Patch Changes - [#2022](#2022) [`266d240ed`](266d240) Thanks [@somewhatabstract](https://github.com/somewhatabstract)! - Update to Wonder Blocks without custom ID generation API - Updated dependencies \[[`4508e7bea`](4508e7b), [`266d240ed`](266d240), [`1fe437079`](1fe4370)]: - @khanacademy/[email protected] - @khanacademy/[email protected] ## @khanacademy/[email protected] ### Patch Changes - [#2022](#2022) [`266d240ed`](266d240) Thanks [@somewhatabstract](https://github.com/somewhatabstract)! - Update to Wonder Blocks without custom ID generation API - Updated dependencies \[[`266d240ed`](266d240)]: - @khanacademy/[email protected]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
srprefix.srFormatNumber()to make sure the numbers areformatted correctly.
stringin the stringsinstead of
numbersince they are now usingsrFormatNumber()(which returns a string)Issue: https://khanacademy.atlassian.net/browse/LEMS-1706
Test plan:
yarn jest