Change device actions to POST and add stale device cleanup standard #3356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Breaks backward compatibility with API, so we can't accept this. Tip: Try PowerShells ternary operator to easily fix. |
I think I've already done this in this commit here :) |
|
ah no youre right, i forgot the tenant filter, ill fix that now |
|
Adding two comments inline |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update device action requests from GET to POST for consistency and introduce a new standard for cleaning up stale Entra devices with a configurable age threshold.
API PR: KelvinTegelaar/CIPP-API#1247