Merge pull request #3356 from kris6673/devices

Change device actions to POST and add stale device cleanup standard

Author: KelvinTegelaar

src/data/standards.json

@@ -674,6 +674,30 @@
     "powershellEquivalent": "",
     "recommendedBy": []
   },
+  {
+    "name": "standards.StaleEntraDevices",
+    "cat": "Entra (AAD) Standards",
+    "tag": ["highimpact", "CIS"],
+    "helpText": "Cleans up Entra devices that have not connected/signed in for the specified number of days.",
+    "docsDescription": "Cleans up Entra devices that have not connected/signed in for the specified number of days. First disables and later deletes the devices. More info can be found in the [Microsoft documentation](https://learn.microsoft.com/en-us/entra/identity/devices/manage-stale-devices)",
+    "addedComponent": [
+      {
+        "type": "number",
+        "name": "standards.StaleEntraDevices.deviceAgeThreshold",
+        "label": "Days before stale(Dont set below 30)"
+      }
+    ],
+    "disabledFeatures": {
+      "report": false,
+      "warn": false,
+      "remediate": true
+    },
+    "label": "Cleanup stale Entra devices",
+    "impact": "High Impact",
+    "impactColour": "danger",
+    "powershellEquivalent": "Remove-MgDevice, Update-MgDevice or Graph API",
+    "recommendedBy": []
+  },
   {
     "name": "standards.UndoOauth",
     "cat": "Entra (AAD) Standards",

src/pages/identity/administration/devices/index.js

@@ -4,57 +4,51 @@ import { Layout as DashboardLayout } from "/src/layouts/index.js"; // had to add
 const Page = () => {
   const pageTitle = "Devices";
   const actions = [
-    // these are currently GET requests that should be converted to POST requests.
     {
       label: "Enable Device",
-      type: "GET",
+      type: "POST",
       url: "/api/ExecDeviceDelete",
       data: {
         ID: "id",
-        Action: "!Enable",
+        action: "!Enable",
       },
       confirmText: "Are you sure you want to enable this device?",
       multiPost: false,
     },
     {
       label: "Disable Device",
-      type: "GET",
+      type: "POST",
       url: "/api/ExecDeviceDelete",
       data: {
         ID: "id",
-        Action: "!Disable",
+        action: "!Disable",
       },
       confirmText: "Are you sure you want to disable this device?",
       multiPost: false,
     },
     {
-      label: "Retrieve Bitlocker Keys",
+      label: "Retrieve BitLocker Keys",
       type: "GET",
       url: "/api/ExecGetRecoveryKey",
       data: {
         GUID: "id",
       },
-      confirmText: "Are you sure you want to retrieve the Bitlocker keys?",
+      confirmText: "Are you sure you want to retrieve the BitLocker keys?",
       multiPost: false,
     },
     {
       label: "Delete Device",
-      type: "GET",
+      type: "POST",
       url: "/api/ExecDeviceDelete",
       data: {
         ID: "id",
-        Action: "!Delete",
+        action: "!Delete",
       },
       confirmText: "Are you sure you want to delete this device?",
       multiPost: false,
     },
   ];
 
-  const offCanvas = {
-    extendedInfoFields: ["createdDateTime", "displayName", "id"],
-    actions: actions,
-  };
-
   return (
     <CippTablePage
       title={pageTitle}
@@ -66,7 +60,6 @@ const Page = () => {
       }}
       apiDataKey="Results"
       actions={actions}
-      offCanvas={offCanvas}
       simpleColumns={[
         "displayName",
         "accountEnabled",
@@ -77,6 +70,7 @@ const Page = () => {
         "operatingSystem",
         "operatingSystemVersion",
         "profileType",
+        "approximateLastSignInDateTime",
       ]}
     />
   );