Skip to content

Fix issue: ERR healthd: Get unit status determine-reboot-cause-'LoadState' #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Junchao-Mellanox
Copy link
Owner

@Junchao-Mellanox Junchao-Mellanox commented Feb 6, 2023

Why I did it

Fix issue: ERR healthd: Get unit status determine-reboot-cause-'LoadState'. The error log is only seen on shutdown flow such as fast-reboot/warm-reboot.

In shutdown flow, 'LoadState' might not be available in systemctl status output, using [] might cause a KeyError.

How I did it

Use dict.get instead of []

How to verify it

Manual test

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211

Description for the changelog

Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@Junchao-Mellanox Junchao-Mellanox changed the title Fix issue: ERR healthd: Get unit status determine-reboot-cause-'LoadS… Fix issue: ERR healthd: Get unit status determine-reboot-cause-'LoadState' Feb 6, 2023
@Junchao-Mellanox Junchao-Mellanox deleted the fix-key-error branch February 8, 2023 01:18
Junchao-Mellanox pushed a commit that referenced this pull request Jan 26, 2025
…atically (sonic-net#16870)

src/sonic-telemetry

*   a399feb - (HEAD -> 202205, origin/202205) Merge pull request #155 from zbud-msft/cherry-pick-on-change-mode-202205 (48 minutes ago) [Ying Xie]
|\  
| *   d7ea9fe - Merge branch '202205' into cherry-pick-on-change-mode-202205 (2 hours ago) [Ying Xie]
| |\  
| |/  
|/|   
* |   7623da9 - Merge pull request #165 from zbud-msft/cherry-pick-prepare-state-db-202205 (2 hours ago) [Ying Xie]
|\ \  
| * | a561194 - Cherry pick files from on change deletion commit (17 hours ago) [Zain Budhwani]
|/ /  
| *   3a3f43c - Merge branch '202205' into cherry-pick-on-change-mode-202205 (19 hours ago) [Ying Xie]
| |\  
| |/  
|/|   
* | 818b345 - Merge pull request #162 from zbud-msft/202205_remove_download_image (19 hours ago) [Ying Xie]
* | 1b4d489 - Install necessary deb instead of entire image (19 hours ago) [Zain Budhwani]
 /  
* e494561 - Add key to on change updates (#138) (2 weeks ago) [Zain Budhwani]
Junchao-Mellanox pushed a commit that referenced this pull request May 9, 2025
…AD automatically (sonic-net#999)

#### Why I did it
src/sonic-utilities
```
* af259a72 - (HEAD -> 202412, origin/202412) Fix show platform ssdhealth not showing expected output when a usb flash drive is plugged in (#166) (6 hours ago) [mssonicbld]
* 98949e44 - [SRv6] add support for SRv6 counters (#167) (6 hours ago) [mssonicbld]
* 380345f6 - Merge pull request #165 from mssonicbld/sonicbld/202412-merge (21 hours ago) [mssonicbld]
* 4899593b - Merge branch '202411' of https://github.com/sonic-net/sonic-utilities into 202412 (23 hours ago) [Sonic Automation]
* 606a90a7 - Fixed syslog error "ERR python3:- validateNamespace: Initialize global.." for sfpshow (sonic-net#3849) (30 hours ago) [mssonicbld]
```
#### How I did it
#### How to verify it
#### Description for the changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants