Fix issue: non default counters will be delayed forever #138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keboliu
reviewed
Mar 29, 2022
| entry_info = db.get_entry("FLEX_COUNTER_TABLE", name) | ||
|
|
||
| if not entry_info: | ||
| if (not entry_info) and enable_by_default: |
There was a problem hiding this comment.
why need this judgment? will it be simple to remove it?
|
LGTM |
shlomibitton
approved these changes
Mar 30, 2022
Junchao-Mellanox
pushed a commit
that referenced
this pull request
Jan 12, 2023
[202012][sonic-linkmgrd] submodule update commit efee4d5b807887bae14c16a8a297756739fcc17e (HEAD -> 202012, upstream/202012) Author: Jing Zhang <[email protected]> Date: Mon Oct 3 09:40:55 2022 -0700 [Active-Standby] fix syslog flood caused by `unkown -> standby` switchovers (#137) Description of PR Summary: Fixes # (issue) This is to fix the syslog flood issue caused by repeated switchovers from unknown to standby. The scenario trigged the issue was when xcvrd timed out toggles requests but was able to probe: Linkmgrd toggles to standby -> toggles fails, xcvrd writes unknown -> linkmgrd probes mux state -> xcvrd writes standby -> linkmgrd toggles to standby (previous mux state was unknown, switching to match) -> toggles fails, xcvrd writes unknown -> ... ... sign-off: Jing Zhang [email protected] commit d4de3d31db6512b045c050533cd9e11a92522916 Author: Jing Zhang <[email protected]> Date: Tue Sep 27 10:36:59 2022 -0700 [202012][Cherry-pick] Post switchover reasons to STATE DB (#138) Description of PR Summary: Fixes # (issue) Cherry-pick conflict: ea68e8c Jing Zhang Wed Sep 21 10:52:18 2022 -0700 Post switchover reasons to STATE DB (#131) a5a9f90 Hua Liu Fri Sep 16 09:54:32 2022 +0800 Install libyang to azure pipeline (#132) sign-off: Jing Zhang [email protected]
Junchao-Mellanox
pushed a commit
that referenced
this pull request
Jun 25, 2023
…matically (sonic-net#15134) src/sonic-py-swsssdk * cd4cb1e - (HEAD -> 202205, origin/202205) Loosen the redis version requirement (#138) (5 hours ago) [xumia]
Junchao-Mellanox
pushed a commit
that referenced
this pull request
May 10, 2024
…omatically (sonic-net#18889) #### Why I did it src/sonic-mgmt-common ``` * 328d806 - (HEAD -> master, origin/master, origin/HEAD) Release CString memory to fix memory leak (#138) (11 hours ago) [ganglv] ``` #### How I did it #### How to verify it #### Description for the changelog
Junchao-Mellanox
pushed a commit
that referenced
this pull request
Jan 26, 2025
…atically (sonic-net#16870) src/sonic-telemetry * a399feb - (HEAD -> 202205, origin/202205) Merge pull request #155 from zbud-msft/cherry-pick-on-change-mode-202205 (48 minutes ago) [Ying Xie] |\ | * d7ea9fe - Merge branch '202205' into cherry-pick-on-change-mode-202205 (2 hours ago) [Ying Xie] | |\ | |/ |/| * | 7623da9 - Merge pull request #165 from zbud-msft/cherry-pick-prepare-state-db-202205 (2 hours ago) [Ying Xie] |\ \ | * | a561194 - Cherry pick files from on change deletion commit (17 hours ago) [Zain Budhwani] |/ / | * 3a3f43c - Merge branch '202205' into cherry-pick-on-change-mode-202205 (19 hours ago) [Ying Xie] | |\ | |/ |/| * | 818b345 - Merge pull request #162 from zbud-msft/202205_remove_download_image (19 hours ago) [Ying Xie] * | 1b4d489 - Install necessary deb instead of entire image (19 hours ago) [Zain Budhwani] / * e494561 - Add key to on change updates (#138) (2 weeks ago) [Zain Budhwani]
Junchao-Mellanox
pushed a commit
that referenced
this pull request
Mar 7, 2025
…atically (sonic-net#751) #### Why I did it src/sonic-utilities ``` * eee330e6 - (HEAD -> 202412, origin/202412) [code sync] Merge code from sonic-net/sonic-utilities:202411 to 202412 (#138) (20 hours ago) [mssonicbld] ``` #### How I did it #### How to verify it #### Description for the changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Fastboot will delay all counters in CONFIG DB, it replies on enable_counters.py to recover the delayed counters. However, enable_counters.py does not recover those non-default counters.
How I did it
For non-default counters, if it is in CONFIG DB, put delay status to false after the waiting.
How to verify it
Manual test
Which release branch to backport (provide reason below if selected)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)