Skip to content

fix RIDER-73086 Advanced Unity integration is unavailable #2240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jan 13, 2022

Conversation

van800
Copy link
Member

@van800 van800 commented Jan 12, 2022

fix RIDER-73086 Advanced Unity integration is unavailable
Specifically, now we will:

  • not show notification, when projects are not loaded
  • hide OutOfSync notification, which was shown before, when next attempt of protocol connection starts

fix DEXP-619767 The path is not a valid file system path because it i…

this was part of #2223

@van800 van800 changed the title Fixes for Notifications RIDER-73086 Advanced Unity integration is unavailable Jan 12, 2022
@van800 van800 requested a review from citizenmatt January 12, 2022 10:31
@van800 van800 self-assigned this Jan 12, 2022
@van800 van800 added this to the Rider 2022.1 milestone Jan 12, 2022
@van800 van800 changed the title RIDER-73086 Advanced Unity integration is unavailable fix RIDER-73086 Advanced Unity integration is unavailable Jan 12, 2022
@van800
Copy link
Member Author

van800 commented Jan 12, 2022

fixing tests ...

@van800 van800 force-pushed the net221-nothifications branch from 620926e to 1082058 Compare January 12, 2022 13:13
@van800 van800 force-pushed the net221-nothifications branch from fc92e92 to 5ca1ea0 Compare January 13, 2022 07:34
Copy link
Member

@citizenmatt citizenmatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@van800 van800 merged commit 234c6bd into net221 Jan 13, 2022
@van800 van800 deleted the net221-nothifications branch January 13, 2022 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants