Notification on Rider package update availability #2223
Conversation
resharper/resharper-unity/src/Rider/RiderPackageUpdateAvailabilityChecker.cs
Outdated
Show resolved
Hide resolved
resharper/resharper-unity/src/Rider/RiderPackageUpdateAvailabilityChecker.cs
Outdated
Show resolved
Hide resolved
| if (id == myHyperlinkId) | ||
| { | ||
| mySettingsStore.BindToContextTransient(ContextRange.ManuallyRestrictWritesToOneContext(mySolution.ToDataContext())) | ||
| .SetValue((UnitySettings key) => key.AllowRiderUpdateNotifications, false); |
There was a problem hiding this comment.
This writes to .sln.DotSettings, doesn't it? Might be better to use the persistent solution properties, which are stored in the ReSharper cache folder, rather than the user's settings.
There was a problem hiding this comment.
It goes to .sln.DotSettings.user
There was a problem hiding this comment.
If I start using persistent solution properties, how user would enable it back if occasionally turn off with the link in the popup? In the current implementation, I have a setting with a checkbox in the Preferences.
|
Nice! I like the idea of checking with the registry - that helps with the scenario of a newer Unity and older Rider. This will show the notification in Rider. Are we interested in showing it in Unity at all? I'm not sure if they have a notifications API, but we can add something to the log? Or do you think it's best to just keep it in Rider? |
I want to keep it in Rider only. |
@citizenmatt what do you think?
The idea is to have both hard-coded expected version of the Rider package (3.0.7) and if protocol is available, we call the code on the EditorPlugin side to get more accurate newest compatible expected version.