Skip to content

Refine text for update available #13010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 27, 2025
Merged

Refine text for update available #13010

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e989eaa
Refine texts
subhramit Apr 27, 2025
9974994
Update l10n
subhramit Apr 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions jabgui/src/main/java/org/jabref/gui/help/NewVersionDialog.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,15 +37,15 @@ public NewVersionDialog(Version currentVersion,
Button defaultButton = (Button) this.getDialogPane().lookupButton(btnDownloadUpdate);
defaultButton.setDefaultButton(true);

Hyperlink lblMoreInformation = new Hyperlink(Localization.lang("To see what is new view the changelog."));
Hyperlink lblMoreInformation = new Hyperlink(Localization.lang("See what's new"));
lblMoreInformation.setOnAction(event ->
NativeDesktop.openBrowserShowPopup(latestVersion.getChangelogUrl(), dialogService, externalApplicationsPreferences)
);

VBox container = new VBox(
new Label(Localization.lang("A new version of JabRef has been released.")),
new Label(Localization.lang("Installed version") + ": " + currentVersion.getFullVersion()),
new Label(Localization.lang("A new version of JabRef is available!")),
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The label text ends with an exclamation mark, which should be avoided as it is more for screaming. A period should be used instead.

new Label(Localization.lang("Latest version") + ": " + latestVersion.getFullVersion()),
new Label(Localization.lang("Installed version") + ": " + currentVersion.getFullVersion()),
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Labels should not end with a colon. The colon should be removed to follow the guidelines for label text formatting.

lblMoreInformation
);
getDialogPane().setContent(container);
Expand Down
4 changes: 2 additions & 2 deletions jablib/src/main/resources/l10n/JabRef_en.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1686,8 +1686,8 @@ Remind\ me\ later=Remind me later
Ignore\ this\ update=Ignore this update
Could\ not\ connect\ to\ the\ update\ server.=Could not connect to the update server.
Please\ try\ again\ later\ and/or\ check\ your\ network\ connection.=Please try again later and/or check your network connection.
To\ see\ what\ is\ new\ view\ the\ changelog.=To see what is new view the changelog.
A\ new\ version\ of\ JabRef\ has\ been\ released.=A new version of JabRef has been released.
See\ what's\ new=See what's new
A\ new\ version\ of\ JabRef\ is\ available!=A new version of JabRef is available!
JabRef\ is\ up-to-date.=JabRef is up-to-date.
Latest\ version=Latest version
Community=Community
Expand Down