Refine text for update available #13010
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: subhramit <[email protected]>
![trag-bot[bot]](https://avatars.githubusercontent.com/in/856808?s=60&v=4){kind=small}
| lblMoreInformation.setOnAction(event -> | ||
| NativeDesktop.openBrowserShowPopup(latestVersion.getChangelogUrl(), dialogService, externalApplicationsPreferences) | ||
| ); | ||
|
|
||
| VBox container = new VBox( | ||
| new Label(Localization.lang("A new version of JabRef has been released.")), | ||
| new Label(Localization.lang("Installed version") + ": " + currentVersion.getFullVersion()), | ||
| new Label(Localization.lang("A new version of JabRef is available!")), |
There was a problem hiding this comment.
The label text ends with an exclamation mark, which should be avoided as it is more for screaming. A period should be used instead.
| new Label(Localization.lang("Latest version") + ": " + latestVersion.getFullVersion()), | ||
| new Label(Localization.lang("Installed version") + ": " + currentVersion.getFullVersion()), |
There was a problem hiding this comment.
Labels should not end with a colon. The colon should be removed to follow the guidelines for label text formatting.
Signed-off-by: subhramit <[email protected]>
|
@trag-bot didn't find any issues in the code! ✅✨ |
|
The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build. |
koppor
approved these changes
Apr 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Based on internal discussion]
Make the text to invite people to update (or at least check out changes in new version) more convincing.
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if change is visible to the user)