Photos in POIs not properly oriented

[valleyofdawn]

Bug

What I expect to happen

When I take a picture for a private POI I expect it to appear properly oriented

What really happened

They appear up-side-down or sideways, depending on how I took the picture

What I did that caused the issue - step by step

Manually added a POI.
Took a picture
Approved it
Looked at the orientation

My environment

App on android

Thing I think the developers should know, images, links etc.

[HarelM]

I'm unable to reproduce it on my device.
Also, I did not change the code that resize and rotates the image.
Please see if this happens also in mobile site, both beta and non beta.
Chances are that your picture has an incorrect orientation value.

[valleyofdawn]

It doesn't happen on the mobile site.
The images have the correct orientation when viewed in the gallery.
Samsung note 9.

[HarelM]

Can you try and see if you can open the site with the phone's default browser (probably Samsung internet) and see if this issue happens there?
I have no clue what can cause this, maybe I can create a debug version for you to test it with. I'll see what I can do...

[valleyofdawn]

Looks OK in the default browser as well.

[HarelM]

@valleyofdawn please try and install the version that will be created in the following build:
https://ci.appveyor.com/project/IsraelHikingHost/site/builds/21870824/job/23bnsfda4u9miqa0
It should popup messages when importing the image to private POI.
The most important message is the "orientation before ...", let me know once you test it what are the popup saying.

[HarelM]

@valleyofdawn any updates on this?

[HarelM]

@valleyofdawn still waiting for your input on this...

[valleyofdawn]

Orientation before undefined

[HarelM]

Is this the only message you are getting? Should be around 3...
Also, if this is the case, no wonder the site doesn't change orientation.
Can you upload the image to this thread as well?

[valleyofdawn]

1 resizing image and fixing orientation
2 uploading image
3 Orientation before undefined

[valleyofdawn]

Interestingly, when shown on google photos it is correctly oriented. unlike above.

[HarelM]

OK, I'm able to reproduce the issue with the above image using my android app (doesn't reproduce on my desktop though).
There's also a strange behavior that the camera icon is begin pressed when adding a private POI, I'll look into it as well...

[HarelM]

I have opened a separate bug related to camera icon behavior in the dialog: #956

[HarelM]

I have no clue what to do here...
The info is there, I'm just not getting it when the code runs inside the cordova app...
hMatoba/piexifjs#60
I hope @hMatoba might be able to help...

[HarelM]

I have also tried using another exif library: exif-js but I get the same results - when using desktop version the file has all the relevant data and when using the same library in cordova app, there's no data returned from the image...
This is very strange... Not sure what to do here...

[zstadler]

According to #238, the issue applies to public POIs too

[HarelM]

It seems that this issue is related to the camera plugin used by the app to get photos from the photos library.
The relevant issue is this one:
apache/cordova-plugin-camera#329
Although seems to be closed I still see the issue occur when using the version from the repository and not from npm.
Fortunately, exif data is not so important when selecting an image for private or public POI and the above issue has allowed me to find a workaround :-)