Skip to content

Private POI dialog is responding to click before it was open #956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
HarelM opened this issue Feb 6, 2019 · 0 comments
Closed

Private POI dialog is responding to click before it was open #956

HarelM opened this issue Feb 6, 2019 · 0 comments
Assignees
Labels
App Native application related issues bug High Needed but there's a work around
Milestone

Comments

@HarelM
Copy link
Member

HarelM commented Feb 6, 2019

Bug

What I expect to happen

Clicking on the map should open the private POI dialog and nothing more

What really happened

The dialog opens and the click is propagated to the dialog

What I did that caused the issue - step by step

  1. Switch to private POI edit mode
  2. Click on the screen where the dialog will show the image add icon
  3. The image add icon gets "clicked" too.

My environment

  • Operating System and version: Android
  • Web Browser and version: App version 8.0.209

Thing I think the developers should know, images, links etc.

Might be an improper event propagation handling in interaction code.

@HarelM HarelM self-assigned this Feb 6, 2019
@HarelM HarelM added bug High Needed but there's a work around labels Feb 6, 2019
@HarelM HarelM added this to the Next Release milestone Feb 6, 2019
@HarelM HarelM closed this as completed in f8d788d Feb 6, 2019
@HarelM HarelM added the App Native application related issues label Feb 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
App Native application related issues bug High Needed but there's a work around
Projects
None yet
Development

No branches or pull requests

1 participant