Skip to content

fix: try removing attachment and fail silently if not attached #3089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

PierreSchwang
Copy link
Member

Overview

Fixes #3025

Description

should "fix" the issue (or rather, suppress the exception if the attachment is not part of the permissible - which is okay as the intention is to remove it either way ig)

### Submitter Checklist
- [x] Make sure you are opening from a topic branch (**/feature/fix/docs/ branch** (right side)) and not your main branch.
- [x] Ensure that the pull request title represents the desired changelog entry.
- [x] New public fields and methods are annotated with `@since TODO`.
- [x] I read and followed the [contribution guidelines](https://github.com/IntellectualSites/.github/blob/main/CONTRIBUTING.md).

@PierreSchwang PierreSchwang requested a review from a team as a code owner January 26, 2025 13:17
@github-actions github-actions bot added the Bugfix This PR fixes a bug label Jan 26, 2025
@NotMyFault NotMyFault merged commit 05bfc4c into main Jan 31, 2025
9 checks passed
@NotMyFault NotMyFault deleted the fix/3025 branch January 31, 2025 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugfix This PR fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when exiting the game
4 participants