Skip to content

Error when exiting the game #3025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 tasks done
wkurumi opened this issue Dec 11, 2024 · 15 comments · Fixed by #3089
Closed
2 tasks done

Error when exiting the game #3025

wkurumi opened this issue Dec 11, 2024 · 15 comments · Fixed by #3089
Labels
More information needed Requires Testing This is a new issue which needs to be approved before labeled with "bug"

Comments

@wkurumi
Copy link

wkurumi commented Dec 11, 2024

Server Implementation

Paper

Server Version

1.21.3

Describe the bug

There is a chance that an error will be reported when exiting the game, but it is not 100%.

To Reproduce

only Exit game

Expected behaviour

none

Screenshots / Videos

No response

Error log (if applicable)

https://paste.gg/p/anonymous/27994e83f6ee471ea78dae6bcd839d9b

Fawe Debugpaste

FAWE report written to https://athion.net/ISPaster/paste/view/bbd5d7aeba0345418ef8eabb2d6f7b45

Fawe Version

FastAsyncWorldEdit-Paper-2.12.3-SNAPSHOT-990

Checklist

Anything else?

No response

@wkurumi wkurumi added the Requires Testing This is a new issue which needs to be approved before labeled with "bug" label Dec 11, 2024
@xPhantoMTVx
Copy link

Having same issue. Seems like fawe in crashing paper-1.21.3-81.jar while performing set command on size larger than 100k

@OneLiteFeather
Copy link
Member

Having same issue. Seems like fawe in crashing paper-1.21.3-81.jar while performing set command on size larger than 100k

this is probably a different issue, please check out the open issues first before opening yours, thank you!

@OneLiteFeather
Copy link
Member

@wkurumi any chance you can try replicating with paper instead? Also can you check if there are errors with your fawe permissions?
Thank you in advance

@indyteo
Copy link

indyteo commented Jan 2, 2025

@wkurumi any chance you can try replicating with paper instead? Also can you check if there are errors with your fawe permissions? Thank you in advance

As I stated in this duplicate issue, I did have this issue with Paper and without LuckPerms:
#3056 (comment)

@bobhenl
Copy link

bobhenl commented Jan 2, 2025

I use paper version but on purpur 1.21.4 @OneLiteFeather
FastAsyncWorldEdit-Paper-2.12.4-SNAPSHOT-1011.jar

@PierreSchwang
Copy link
Member

I can't reproduce that issue with a fresh Paper 1.21.4 server with just FAWE. Can you replicate that with the named setup?

@Techirion
Copy link

> ver
[10:13:25 INFO]: Checking version, please wait...
[10:13:25 INFO]: This server is running Paper version 1.21.4-113-main@8e80d4e (2025-01-14T18:27:40Z) (Implementing API version 1.21.4-R0.1-SNAPSHOT)
You are running the latest version
Previous version: 1.21.4-110-c44f891 (MC: 1.21.4
> ver FastAsyncWorldEdit
[10:13:45 INFO]: FastAsyncWorldEdit version 2.12.4-SNAPSHOT-1022;aecc50d
[10:13:45 INFO]: Blazingly fast world manipulation for builders, large networks and developers.
[10:13:45 INFO]: Website: https://www.spigotmc.org/resources/13932/
[10:13:45 INFO]: Authors: Empire92, MattBDev, IronApollo, dordsor21 and NotMyFault

The issue still occurs, but randomly, not on every quit. From 1 of our servers...

"lost connection: " 422 hits so far
"Could not pass event PlayerQuitEvent to FastAsyncWorldEdit v2.12.4-SNAPSHOT-1022;aecc50d" 2 hits so far

Not using LuckPerms but custom permissions plugin.

@IAmStive222
Copy link

hi! did you manage to solve the problem?

@PierreSchwang PierreSchwang marked this as a duplicate of #3088 Jan 26, 2025
@PierreSchwang
Copy link
Member

As it's quite random - is there some correlation between the online-time of the player and the error? Like, does this error rather occur when a player was online and active for a longer time?

@IAmStive222
Copy link

There is! I only noticed this when the last player logged off the server.

@PierreSchwang
Copy link
Member

There is! I only noticed this when the last player logged off the server.

Mhm, weird tbh. I mean, the linked PR "fixes" that either way (theoretically, it just suppresses the error - but as the error indicates that the Attachment is removed, the result is the same ig)

@Techirion
Copy link

As it's quite random - is there some correlation between the online-time of the player and the error? Like, does this error rather occur when a player was online and active for a longer time?

None. Lowest I could find was player who was disconnected after 3 seconds after joining, highest it was hours.

There is! I only noticed this when the last player logged off the server.

We're seeing this for random players over whole day...

There is! I only noticed this when the last player logged off the server.

Mhm, weird tbh. I mean, the linked PR "fixes" that either way (theoretically, it just suppresses the error - but as the error indicates that the Attachment is removed, the result is the same ig)

Is there any chance FAWE would somehow trying to remove attachment twice? Cause of some strange Paper, Via or whatever bug? I can also see this on empty testing server as well as on "prod" server with 100 players that would have some TPS drops from time to time, didn't managed to replicate it tho...

@dordsor21
Copy link
Member

Is there any chance FAWE would somehow trying to remove attachment twice? Cause of some strange Paper, Via or whatever bug? I can also see this on empty testing server as well as on "prod" server with 100 players that would have some TPS drops from time to time, didn't managed to replicate it tho...

Do you know if/that the attachment is actually still assigned to the player when the error occurs?

@Techirion
Copy link

FAWE attachment? I'm not sure.

https://github.com/IntellectualSites/FastAsyncWorldEdit/blob/aecc50d7f5a05e4926581f145ab60a2382bae352/worldedit-bukkit/src/main/java/com/fastasyncworldedit/bukkit/BukkitPermissionAttachmentManager.java

I'd have to write plugin to get data from BukkitPermissionAttachmentManager and check if attachment is there in every priority in quit event?

Also I've just noticed, this permission attachment would be tied to instance of plugin right? That would be WorldEditPlugin class? Or FAWE? Not sure when the magic happens (WorldEdit plugin becomes FastAsyncWorldEdit when only FastAsyncWorldEdit .jar is present)? Also could that potentially be an issue?

@thiagogebrimm
Copy link

i have the same problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
More information needed Requires Testing This is a new issue which needs to be approved before labeled with "bug"
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants