Skip to content

[UX] Fix position of dialog header #3392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 6, 2024
Merged

[UX] Fix position of dialog header #3392

merged 2 commits into from
Jan 6, 2024

Conversation

arielj
Copy link
Collaborator

@arielj arielj commented Jan 5, 2024

This PR fixes #2609 by making all dialog headers static.

Also, now that we are not closing the dialogs when clicking outside (until we figure a solution for this #3194) it was sometimes annoying to have to scroll up to close a dialog.

dialog-haeder.mp4

This also fixes this issue with changelogs not having a height limit:

image


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@arielj arielj added the pr:ready-for-review Feature-complete, ready for the grind! :P label Jan 5, 2024
@arielj arielj requested review from a team, flavioislima, CommandMC, Etaash-mathamsetty, Nocccer and imLinguin and removed request for a team January 5, 2024 22:59
Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good stuff

@arielj arielj merged commit 437a0c5 into main Jan 6, 2024
@arielj arielj deleted the fixed-dialog-header branch January 6, 2024 23:10
@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators Jan 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make changelog header static
2 participants