Skip to content

Make changelog header static #2609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JordanPlayz158 opened this issue Apr 7, 2023 · 3 comments · Fixed by #3392
Closed

Make changelog header static #2609

JordanPlayz158 opened this issue Apr 7, 2023 · 3 comments · Fixed by #3392

Comments

@JordanPlayz158
Copy link
Contributor

Problem description

When I scroll through the changelog, once I scroll to the bottom (reach the end), I would like to be able to close it without needing to scroll to the top again. I think this makes sense as that is the flow that feels natural (opinionated but I think this is present in many applications).

Feature description

Make it so the header (which has the X button) does not scroll up with the main body (the changelog itself) so it can be exited out at any point.

Alternatives

If not already present, allow clicking outside of the changelog box to also close the box as the X button would.

Additional information

No response

@flavioislima
Copy link
Member

In case you don't know you can just click outside the modal and it will close. All modals can be closed like this on Heroic.

@JordanPlayz158
Copy link
Contributor Author

Yeah, I did notice this by accident, I think the reason it was not obvious to me is because when I see an X button, I assume the reason it is there as that is the way to close it, perhaps if we remove the X or make the header static it could be better or maybe I'm just not the normal user and these trends of having an X button but also being able to close by clicking the unfocused/overlay area is just a known thing now but if we do have the X, I do ultimately feel the expected behavior is for the header to stay always at the top

@arielj
Copy link
Collaborator

arielj commented Apr 28, 2023

I think the X should be static, I think it makes it easier to get there when using a controller

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants