[BUG] Don't add shortcut for DLCs. Fix adding sideload app shortcuts #2778
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arielj
requested review from
a team,
flavioislima,
CommandMC,
Nocccer and
imLinguin
and removed request for
a team
arielj
commented
Jun 4, 2023
| @@ -125,7 +126,7 @@ export async function uninstall({ | |||
|
|
|||
| notify({ title, body: i18next.t('notify.uninstalled') }) | |||
|
|
|||
| removeShortcuts(appName) | |||
| removeShortcutsUtil(gameInfo) | |||
There was a problem hiding this comment.
we already have the gameInfo here, no need to call the function that looks for the gameInfo
arielj
commented
Jun 4, 2023
| @@ -59,7 +60,7 @@ export function addNewApp({ | |||
| current[gameIndex] = { ...current[gameIndex], ...game } | |||
| } else { | |||
| current.push(game) | |||
| addShortcuts(app_name) | |||
| addShortcuts(game) | |||
There was a problem hiding this comment.
we already have the gameInfo here, no need to call the function that looks for the gameInfo
arielj
commented
Jun 4, 2023
| @@ -27,7 +27,8 @@ export function addNewApp({ | |||
| title, | |||
| install: { | |||
| executable, | |||
| platform | |||
| platform, | |||
| is_dlc: false | |||
There was a problem hiding this comment.
mark it as not DLC just to be explicit since now we check if is_dlc is true to ignore the shortcuts
flavioislima
approved these changes
Jun 4, 2023
flavioislima
approved these changes
Jun 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two issues:
This fixes #2756
Use the following Checklist if you have changed something on the Backend or Frontend: