Skip to content

Error in backend after adding sideloaded app #2756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
arielj opened this issue Jun 2, 2023 · 0 comments · Fixed by #2778
Closed

Error in backend after adding sideloaded app #2756

arielj opened this issue Jun 2, 2023 · 0 comments · Fixed by #2778

Comments

@arielj
Copy link
Collaborator

arielj commented Jun 2, 2023

Describe the bug

After adding an app with Add Game, this errors show up in the logs related to extra game info and shortcuts

Add logs

(00:47:56) INFO:    [Backend]:          Adding shortcuts for undefined
(00:47:56) ERROR:   [ExtraGameInfo]:    Was not able to get ExtraGameInfo data for undefined TypeError: Cannot read properties of undefined (reading 'replaceAll')
    at removeSpecialcharacters (/home/ariel/dev/oss/HeroicGamesLauncher/build/electron/main.c42fbcef.js:7981:15)
    at getWikiGameInfo (/home/ariel/dev/oss/HeroicGamesLauncher/build/electron/main.c42fbcef.js:2555:13)
    at addNonSteamGame (/home/ariel/dev/oss/HeroicGamesLauncher/build/electron/main.c42fbcef.js:2691:26)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
(00:47:56) WARNING: [Shortcuts]:        Couldn't find a icon for undefined with: TypeError: Cannot read properties of undefined (reading 'replaceAll')
    at getIcon$1 (/home/ariel/dev/oss/HeroicGamesLauncher/build/electron/main.c42fbcef.js:2139:35)
    at addNonSteamGame (/home/ariel/dev/oss/HeroicGamesLauncher/build/electron/main.c42fbcef.js:2744:11)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
(00:47:56) INFO:    [Shortcuts]:        Prepare Steam images for undefined
(node:219585) UnhandledPromiseRejectionWarning: Error: Input must be string
    at sanitize (/home/ariel/dev/oss/HeroicGamesLauncher/node_modules/sanitize-filename/index.js:41:11)
    at module.exports [as default] (/home/ariel/dev/oss/HeroicGamesLauncher/node_modules/sanitize-filename/index.js:54:16)
    at shortcutFiles (/home/ariel/dev/oss/HeroicGamesLauncher/build/electron/main.c42fbcef.js:3020:40)
    at addShortcuts$3 (/home/ariel/dev/oss/HeroicGamesLauncher/build/electron/main.c42fbcef.js:2935:35)
    at addShortcuts$2 (/home/ariel/dev/oss/HeroicGamesLauncher/build/electron/main.c42fbcef.js:3127:10)
    at addNewApp (/home/ariel/dev/oss/HeroicGamesLauncher/build/electron/main.c42fbcef.js:4730:5)
    at IpcMainImpl.<anonymous> (/home/ariel/dev/oss/HeroicGamesLauncher/build/electron/main.c42fbcef.js:15756:49)
    at IpcMainImpl.emit (node:events:513:28)
    at EventEmitter.<anonymous> (node:electron/js2c/browser_init:2:81053)
    at EventEmitter.emit (node:events:513:28)
(node:219585) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 7)

Steps to reproduce

  1. Add a sideloaded app with Add Game
  2. Check the logs

Expected behavior

there should be no errors

Screenshots

No response

Heroic Version

Latest Stable

System Information

not relevant

Additional information

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant