-
-
Notifications
You must be signed in to change notification settings - Fork 480
[GOG]: Switch to Galaxy way of loading library #2759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
1c409a5
feat: galaxy way of loading library
imLinguin b117456
fix: lint
imLinguin 475cf19
remove sorting_title, fix cloud saves false positives
imLinguin 5f8b458
feat: gamesdb caching, library pagination
imLinguin b439bda
fix: small issues found thanks to tests
imLinguin 148c0d8
Pull upstream
imLinguin 12bc641
feat: add installable boolean to GameInfo
imLinguin a1fcceb
fix: pr suggestions
imLinguin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,7 +11,8 @@ import { | |
createReqsArray, | ||
getGameInfo as getGogLibraryGameInfo, | ||
changeGameInstallPath, | ||
getMetaResponse | ||
getMetaResponse, | ||
getGamesData | ||
} from './library' | ||
import { join } from 'path' | ||
import { GameConfig } from '../../game_config' | ||
|
@@ -80,7 +81,7 @@ export async function getExtraInfo(appName: string): Promise<ExtraInfo> { | |
const extra: ExtraInfo = { | ||
about: gameInfo.extra?.about, | ||
reqs: await createReqsArray(appName, targetPlatform), | ||
storeUrl: gameInfo.store_url | ||
storeUrl: (await getGamesData(appName))?._links.store.href | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I know this works, nice. But I still think that we should solve promises before defining the values of this object, for both this and the previous key. |
||
} | ||
return extra | ||
} | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add a default text here.